Bug 1892465 - Fish functions should go in vendor_functions.d, not vendor_conf.d
Summary: Fish functions should go in vendor_functions.d, not vendor_conf.d
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: vim
Version: 33
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Karsten
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-10-28 20:34 UTC by Daniel Moerner
Modified: 2020-12-09 10:27 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-12-09 10:27:19 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Daniel Moerner 2020-10-28 20:34:45 UTC
Description of problem:

If the user has already defined a fish function for "vim" (e.g., by aliasing vim to nvim), a vendor-shipped function in /usr/share/fish/vendor_conf.d will disable function autoloading and override that function. The user's choices should be respected.

Version-Release number of selected component (if applicable):

vim-minimal 2:8.2.1885-1, in F32, F33, and rawhide.

How reproducible:

100%

Additional info:

I believe that all that needs to be done is that the vim.fish file should be installed in /usr/share/fish/vendor_functions.d, not /usr/share/fish/vendor_conf.d. Putting them in the conf directory turns off autoloading for functions with that name.

Thank you to upstream for helping figure this out. https://github.com/fish-shell/fish-shell/issues/7434

Comment 1 Fedora Update System 2020-11-02 11:55:35 UTC
FEDORA-2020-84a019a46b has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-84a019a46b

Comment 2 Fedora Update System 2020-11-02 11:55:45 UTC
FEDORA-2020-468809b1bc has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-468809b1bc

Comment 3 Fedora Update System 2020-11-02 11:55:55 UTC
FEDORA-2020-2f6168af2a has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-2f6168af2a

Comment 4 Zdenek Dohnal 2020-11-02 11:57:06 UTC
Hi Daniel,

thank you for reporting the issue and proposing the fix!

The fixed package landed into bodhi.fedoraproject.org right know, feel free to check.

Comment 5 Fedora Update System 2020-11-03 02:25:26 UTC
FEDORA-2020-84a019a46b has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-84a019a46b`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-84a019a46b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2020-11-03 02:26:16 UTC
FEDORA-2020-468809b1bc has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-468809b1bc`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-468809b1bc

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2020-11-03 02:34:48 UTC
FEDORA-2020-2f6168af2a has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-2f6168af2a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-2f6168af2a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2020-11-05 01:03:23 UTC
FEDORA-2020-84a019a46b has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2020-11-09 01:21:17 UTC
FEDORA-2020-468809b1bc has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2020-11-18 03:03:16 UTC
FEDORA-2020-2f6168af2a has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Zdenek Dohnal 2020-12-09 10:27:19 UTC
Seems the automaton doesn't work - all updates are in stable now, closing as ERRATA.


Note You need to log in before you can comment on or make changes to this bug.