Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://download.copr.fedorainfracloud.org/results/gicmo/koji-osbuild/fedora-rawhide-x86_64/01741573-koji-osbuild/koji-osbuild.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/gicmo/koji-osbuild/fedora-rawhide-x86_64/01741573-koji-osbuild/koji-osbuild-1-0.fc34.src.rpm Description: This project provides osbuild integration with Koji. It makes it possible to build images and other OS artifacts via osbuild-composer through koji, This is done via three plugins: Koji hub plugin: Provides a new XMLRPC API endpoint that clients can use to create new osbuildImage Koji tasks. Koji builder plugin: Handles osbuildImage Koji tasks and will talk to osbuild-composer to create new composes via composer's Koji API. Koji cli plugin: Adds a new osbuild-image to the existing koji command line client. This will then use the new XMLRPC API to request a new compose. Fedora Account System Username: gicmo Upstream git: https://github.com/osbuild/koji-osbuild
Taking this review.
Please use a URL that resolves to the direct spec file (that is, not a GitHub URL that returns HTML and doesn't match the spec in the SRPM).
(In reply to Neal Gompa from comment #2) > Please use a URL that resolves to the direct spec file (that is, not a > GitHub URL that returns HTML and doesn't match the spec in the SRPM). Ah, good point, sorry. I am sure you figured it out by now, but for the record: https://raw.githubusercontent.com/gicmo/spec/master/koji-osbuild/koji-osbuild.spec
I just edited the original comment to use the spec file that was actually uploaded by copr from the SRPM build for package reviews.
Thanks for starting this process Christian, I'm really excited to see this land! Neal, is there anything I can do to help move the review forward?
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0". 62 files have unknown license. Detailed output of licensecheck in /home/ngompa/1893661-koji-osbuild/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/koji-hub-plugins [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/koji-hub- plugins/__pycache__, /usr/lib/koji-builder-plugins/__pycache__, /usr/lib/koji-hub-plugins, /usr/lib/python3.9/site- packages/koji_cli_plugins, /usr/lib/koji-builder-plugins, /usr/lib/python3.9/site-packages/koji_cli_plugins/__pycache__ [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: koji-osbuild-1-0.fc34.noarch.rpm koji-osbuild-hub-1-0.fc34.noarch.rpm koji-osbuild-builder-1-0.fc34.noarch.rpm koji-osbuild-cli-1-0.fc34.noarch.rpm koji-osbuild-1-0.fc34.src.rpm koji-osbuild-hub.noarch: W: only-non-binary-in-usr-lib koji-osbuild-hub.noarch: W: no-documentation koji-osbuild-builder.noarch: W: only-non-binary-in-usr-lib koji-osbuild-builder.noarch: W: no-documentation koji-osbuild-cli.noarch: W: no-documentation koji-osbuild.src:53: E: hardcoded-library-path in %{_prefix}/lib/koji-hub-plugins koji-osbuild.src:54: E: hardcoded-library-path in %{_prefix}/lib/koji-hub-plugins/ koji-osbuild.src:55: E: hardcoded-library-path in %{_prefix}/lib/koji-hub-plugins/osbuild.py koji-osbuild.src:57: E: hardcoded-library-path in %{_prefix}/lib/koji-builder-plugins koji-osbuild.src:58: E: hardcoded-library-path in %{_prefix}/lib/koji-builder-plugins/ koji-osbuild.src:59: E: hardcoded-library-path in %{_prefix}/lib/koji-builder-plugins/osbuild.py koji-osbuild.src:70: E: hardcoded-library-path in %{_prefix}/lib/koji-hub-plugins/osbuild.py koji-osbuild.src:71: E: hardcoded-library-path in %{_prefix}/lib/koji-hub-plugins/__pycache__/osbuild.* koji-osbuild.src:74: E: hardcoded-library-path in %{_prefix}/lib/koji-builder-plugins/osbuild.py koji-osbuild.src:75: E: hardcoded-library-path in %{_prefix}/lib/koji-builder-plugins/__pycache__/osbuild.* 5 packages and 0 specfiles checked; 10 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- koji-osbuild-cli.noarch: W: no-documentation koji-osbuild-hub.noarch: W: only-non-binary-in-usr-lib koji-osbuild-hub.noarch: W: no-documentation koji-osbuild-builder.noarch: W: only-non-binary-in-usr-lib koji-osbuild-builder.noarch: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 5 warnings. Source checksums ---------------- https://github.com/osbuild/koji-osbuild/archive/v1/koji-osbuild-1.tar.gz : CHECKSUM(SHA256) this package : 3ab83c69c72c3f5fec00606d5cfeb2b350340119c76d71843456ef5b1cfb78e2 CHECKSUM(SHA256) upstream package : 3ab83c69c72c3f5fec00606d5cfeb2b350340119c76d71843456ef5b1cfb78e2 Requires -------- koji-osbuild (rpmlib, GLIBC filtered): koji-osbuild-hub (rpmlib, GLIBC filtered): koji-hub koji-osbuild koji-osbuild-builder (rpmlib, GLIBC filtered): /usr/bin/python3 koji-builder koji-osbuild python3-requests koji-osbuild-cli (rpmlib, GLIBC filtered): koji koji-osbuild python(abi) Provides -------- koji-osbuild: koji-osbuild koji-osbuild-hub: koji-osbuild-hub koji-osbuild-builder: koji-osbuild-builder koji-osbuild-cli: koji-osbuild-cli Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1893661 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: C/C++, Ocaml, fonts, PHP, Java, SugarActivity, Haskell, Perl, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Everything looks good to me. PACKAGE APPROVED.
Thanks Neal!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/koji-osbuild
Package is available in repos, closing ticket.