Bug 1893906

Will need a rebase of all the roles, there were changes needed to support collections.

There are two possible approaches to testing of collections.

First is to use the tests in the collection (converted role tests) under  /usr/share/ansible/collections/ansible_collections/redhat/rhel_system_roles/tests/ and run them using the Upstream-testsuite and/or the basic-smoke-test wrappers. This will require some changes to the wrappers and fixing RHELPLAN-61752, because right now the tests are not converted properly. All the tests will then be executed twice, once for the collection and second time for the legacy role, which is probably not a big problem.

Second possibility is to add a really basic smoke test that checks that the role can be imported from the collection for every role. The playbook looks like (replace fedora by redhat and linux_system_roles by rhel_system_roles for downstream testing):

- hosts: localhost
  collections:
    - fedora.linux_system_roles
  tasks:
    - import_role:
        name: storage
      when: false

If executed on a host where the collection is not installed, it fails:
-----
ERROR! the role 'storage' was not found in fedora.linux_system_roles:ansible.legacy:/home/pcahyna/ansible_pokusy/collections/roles:/home/pcahyna/.ansible/roles:/usr/share/ansible/roles:/etc/ansible/roles:/home/pcahyna/ansible_pokusy/collections

The error appears to be in '/home/pcahyna/ansible_pokusy/collections/simplecollectionimport.yml': line 6, column 15, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

    - import_role:
        name: storage
              ^ here
-----

When the package with collection is installed, it runs:
-----
ansible-playbook -i localhost, simplecollectionimport.yml 

PLAY [localhost] ***************************************************************

TASK [Gathering Facts] *********************************************************
[DEPRECATION WARNING]: Distribution fedora 32 on host localhost should use 
/usr/bin/python3, but is using /usr/bin/python for backward compatibility with 
prior Ansible releases. A future Ansible release will default to using the 
discovered platform python for this host. See https://docs.ansible.com/ansible/
2.9/reference_appendices/interpreter_discovery.html for more information. This 
feature will be removed in version 2.12. Deprecation warnings can be disabled 
by setting deprecation_warnings=False in ansible.cfg.
ok: [localhost]

TASK [fedora.linux_system_roles.storage : Set version specific variables] ******
skipping: [localhost]

TASK [fedora.linux_system_roles.storage : define an empty list of pools to be used in testing] ***
skipping: [localhost]

TASK [fedora.linux_system_roles.storage : define an empty list of volumes to be used in testing] ***
skipping: [localhost]

TASK [fedora.linux_system_roles.storage : include the appropriate provider tasks] ***
skipping: [localhost]

PLAY RECAP *********************************************************************
localhost                  : ok=1    changed=0    unreachable=0    failed=0    skipped=4    rescued=0    ignored=0   
-----

Such test playbook can be easily autogenerated to test all roles in the package.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (rhel-system-roles bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:1909