Bug 1894370 - Review Request: python-logfury - Library for logging of method calls for Python
Summary: Review Request: python-logfury - Library for logging of method calls for Python
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1895111
TreeView+ depends on / blocked
 
Reported: 2020-11-04 07:18 UTC by Jonny Heggheim
Modified: 2020-11-07 18:42 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-11-07 18:42:20 UTC
Type: ---
Embargoed:
gwync: fedora-review+


Attachments (Terms of Use)

Description Jonny Heggheim 2020-11-04 07:18:11 UTC
Spec URL: https://jonny.fedorapeople.org//python-logfury.spec
SRPM URL: https://jonny.fedorapeople.org//python-logfury-0.1.2-1.fc32.src.rpm

Description:
Library for logging of method calls for Python.

Comment 1 Jonny Heggheim 2020-11-04 07:18:15 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=54901738

Comment 2 Jonny Heggheim 2020-11-04 07:19:27 UTC
Library is a dependency for b2sdk that is used by the duplicity b2 plugin

Comment 3 Gwyn Ciesla 2020-11-06 15:58:35 UTC
Good:

- rpmlint checks return:
python-logfury.src:38: W: macro-in-comment %{python3}
There is a unescaped macro after a shell style comment in the specfile. Macros
are expanded everywhere, so check if it can cause a problem in this case and
escape the macro with another leading % if appropriate.

- package meets naming guidelines
- package meets packaging guidelines
- license ( ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 


APPROVED, fix marco comment before import.

Comment 4 Jonny Heggheim 2020-11-06 18:25:58 UTC
(In reply to Gwyn Ciesla from comment #3)
> APPROVED, fix marco comment before import.

Thanks, will fix the macro comment before import.

Comment 5 Gwyn Ciesla 2020-11-06 19:02:03 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-logfury


Note You need to log in before you can comment on or make changes to this bug.