Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1894678

Summary:	Installer panics on invalid flavor
Product:	OpenShift Container Platform	Reporter:	egarcia
Component:	Installer	Assignee:	egarcia
Installer sub component:	OpenShift on OpenStack	QA Contact:	weiwei jiang <wjiang>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	urgent
Priority:	urgent	CC:	cjanisze, egarcia, pprinett, wjiang
Version:	4.6.z
Target Milestone:	---
Target Release:	4.6.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1887863	Environment:
Last Closed:	2021-01-18 17:58:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1887863
Bug Blocks:

Comment 1 Pierre Prinetti 2020-11-19 09:47:14 UTC

Waiting for verification of the 4.7 patch.

Comment 2 Pierre Prinetti 2020-12-22 16:29:43 UTC

The fix to Bug 1899161 (sev: urgent / prio: urgent) depends on this one. Bumping the severity/priority of this one accordingly.

Comment 4 weiwei jiang 2020-12-28 01:45:02 UTC

The latest 4.6 nightly now is 4.6.0-0.nightly-2020-12-21-110104 which is not fixed the issue.

$ ./openshift-install-4.6 create manifests --dir . --log-level debug
DEBUG OpenShift Installer 4.6.0-0.nightly-2020-12-21-110104 
DEBUG Built from commit a48ad4a15b42102d1747d2f5f3b635deffb950b5 
DEBUG Fetching Master Machines...                  
DEBUG Loading Master Machines...                   
DEBUG   Loading Cluster ID...                      
DEBUG     Loading Install Config...                
DEBUG       Loading SSH Key...                     
DEBUG       Loading Base Domain...                 
DEBUG         Loading Platform...                  
DEBUG       Loading Cluster Name...                
DEBUG         Loading Base Domain...               
DEBUG         Loading Platform...                  
DEBUG       Loading Pull Secret...                 
DEBUG       Loading Platform...                    
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x2207cef]

goroutine 1 [running]:
github.com/openshift/installer/pkg/asset/installconfig/openstack/validation.validateMpoolFlavor(0x0, 0xc0007ff500, 0x8, 0x2, 0x19, 0xc0011cd440, 0xc000e9edf8, 0x40e178, 0x30)
        /go/src/github.com/openshift/installer/pkg/asset/installconfig/openstack/validation/machinepool.go:117 +0x4f
github.com/openshift/installer/pkg/asset/installconfig/openstack/validation.ValidateMachinePool(0xc0001859e0, 0xc000119bd0, 0x0, 0xc0011cd440, 0x1, 0x1, 0xc0011cd440)
        /go/src/github.com/openshift/installer/pkg/asset/installconfig/openstack/validation/machinepool.go:50 +0x68a
github.com/openshift/installer/pkg/asset/installconfig/openstack.Validate(0xc00067c900, 0x0, 0x0)
        /go/src/github.com/openshift/installer/pkg/asset/installconfig/openstack/validate.go:28 +0x3a5
github.com/openshift/installer/pkg/asset/installconfig.(*InstallConfig).platformValidation(0xc000398be0, 0x0, 0x0)
        /go/src/github.com/openshift/installer/pkg/asset/installconfig/installconfig.go:188 +0x87
github.com/openshift/installer/pkg/asset/installconfig.(*InstallConfig).finish(0xc000398be0, 0xd4f034c, 0x13, 0x19e3, 0xd216c40)
        /go/src/github.com/openshift/installer/pkg/asset/installconfig/installconfig.go:148 +0x234
github.com/openshift/installer/pkg/asset/installconfig.(*InstallConfig).Load(0xc000398be0, 0xe7ca140, 0xc0000ad650, 0xe8beb00, 0xc000398be0, 0xc000398be0)
        /go/src/github.com/openshift/installer/pkg/asset/installconfig/installconfig.go:125 +0x1f0
github.com/openshift/installer/pkg/asset/store.(*storeImpl).load(0xc00045a330, 0xe7f47c0, 0xc00000dd00, 0xc000758c7c, 0x4, 0xc000758c7c, 0x4, 0x0)
        /go/src/github.com/openshift/installer/pkg/asset/store/store.go:264 +0x455
github.com/openshift/installer/pkg/asset/store.(*storeImpl).load(0xc00045a330, 0xe7f4780, 0xc00000dbe0, 0xd483a24, 0x2, 0xd483a24, 0x2, 0x0)
        /go/src/github.com/openshift/installer/pkg/asset/store/store.go:247 +0x2d7
github.com/openshift/installer/pkg/asset/store.(*storeImpl).load(0xc00045a330, 0xe7f4b00, 0x154c3480, 0x0, 0x0, 0x2, 0x2, 0xe7417c0)
        /go/src/github.com/openshift/installer/pkg/asset/store/store.go:247 +0x2d7
github.com/openshift/installer/pkg/asset/store.(*storeImpl).fetch(0xc00045a330, 0xe7f4b00, 0x154c3480, 0x0, 0x0, 0x40b525, 0xbf8ce20)
        /go/src/github.com/openshift/installer/pkg/asset/store/store.go:201 +0xa3a
github.com/openshift/installer/pkg/asset/store.(*storeImpl).Fetch(0xc00045a330, 0xe7f4b00, 0x154c3480, 0x1547f8e0, 0x4, 0x4, 0xae00000000000000, 0xed77b2f08)
        /go/src/github.com/openshift/installer/pkg/asset/store/store.go:77 +0x4b
main.runTargetCmd.func1(0x7ffcfdfe0d4c, 0x1, 0xc00000da00, 0xc000322420)
        /go/src/github.com/openshift/installer/cmd/openshift-install/create.go:172 +0x135
main.runTargetCmd.func2(0x1548b2a0, 0xc000827e80, 0x0, 0x4)
        /go/src/github.com/openshift/installer/cmd/openshift-install/create.go:199 +0xb5
github.com/spf13/cobra.(*Command).execute(0x1548b2a0, 0xc000827e40, 0x4, 0x4, 0x1548b2a0, 0xc000827e40)
        /go/src/github.com/openshift/installer/vendor/github.com/spf13/cobra/command.go:844 +0x2c2
github.com/spf13/cobra.(*Command).ExecuteC(0xc000e62000, 0xc000b9fe58, 0x1, 0x1)
        /go/src/github.com/openshift/installer/vendor/github.com/spf13/cobra/command.go:945 +0x336
github.com/spf13/cobra.(*Command).Execute(...)
        /go/src/github.com/openshift/installer/vendor/github.com/spf13/cobra/command.go:885
main.installerMain()
        /go/src/github.com/openshift/installer/cmd/openshift-install/main.go:63 +0x2b8
main.main()
        /go/src/github.com/openshift/installer/cmd/openshift-install/main.go:43 +0xcf

Comment 5 Pierre Prinetti 2020-12-28 23:08:07 UTC

Indeed, the patch was merged 2020-12-21T17:59:00Z. Moving back to ON_QA as there's not much we can do until there's a nightly.

Comment 6 weiwei jiang 2021-01-04 05:49:16 UTC

Checked with 4.6.0-0.nightly-2021-01-03-162024 and it's fixed now.

$ ./openshift-install-4.6 version
./openshift-install-4.6 4.6.0-0.nightly-2021-01-03-162024
built from commit eded5eb5b6c77e2af2a2c537093da8bf3711f494
release image registry.ci.openshift.org/ocp/release@sha256:1004f37482f3f3e850d9b27bee6cd95cb80a4f167b56bf368a4f103c560a74fa
$ ./openshift-install-4.6 create manifests --dir . --log-level debug    
DEBUG OpenShift Installer 4.6.0-0.nightly-2021-01-03-162024 
DEBUG Built from commit eded5eb5b6c77e2af2a2c537093da8bf3711f494 
DEBUG Fetching Master Machines...                  
DEBUG Loading Master Machines...                   
DEBUG   Loading Cluster ID...                      
DEBUG     Loading Install Config...                
DEBUG       Loading SSH Key...                     
DEBUG       Loading Base Domain...                 
DEBUG         Loading Platform...                  
DEBUG       Loading Cluster Name...                
DEBUG         Loading Base Domain...               
DEBUG         Loading Platform...                  
DEBUG       Loading Pull Secret...                 
DEBUG       Loading Platform...                    
FATAL failed to fetch Master Machines: failed to load asset "Install Config": compute[0].platform.openstack.type: Not found: "non-existed"

Comment 9 errata-xmlrpc 2021-01-18 17:58:37 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.6.12 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:0037