Bug 1894860 - 'backend' CI job passing despite failing tests
Summary: 'backend' CI job passing despite failing tests
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.7
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.7.0
Assignee: Predrag Knezevic
QA Contact: Yanping Zhang
URL:
Whiteboard:
Depends On:
Blocks: 1894868
TreeView+ depends on / blocked
 
Reported: 2020-11-05 10:00 UTC by Predrag Knezevic
Modified: 2021-02-24 15:31 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
: 1894868 (view as bug list)
Environment:
Last Closed: 2021-02-24 15:31:24 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 7111 0 None closed Bug 1894860: fixed test "returned merged index file for all accessible helm repos" 2021-01-18 10:24:01 UTC
Github openshift console pull 7116 0 None closed Bug 1894860: Correctly report errors when backend tests fail 2021-01-18 10:24:01 UTC
Red Hat Product Errata RHSA-2020:5633 0 None None None 2021-02-24 15:31:54 UTC

Description Predrag Knezevic 2020-11-05 10:00:16 UTC 
Description of problem:

'backend' CI job triggered on each PR is passing despite failing tests. For example:

https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_console/7099/pull-ci-openshift-console-master-backend/1323911973502455808
Comment 1 Samuel Padgett 2020-11-05 14:39:59 UTC 
I think this was introduced by https://github.com/openshift/console/pull/6400

We don't have `set -o pipefail` set, so apparently `go test -v "${COVER}" "$@" "${TEST[@]}" 2>&1 | tee /tmp/artifacts/test.out` doesn't fail.
Comment 3 Yanping Zhang 2020-11-12 08:12:40 UTC 
Checked job history, now there are failed jobs and passed jobs: https://prow.ci.openshift.org/job-history/gs/origin-ci-test/pr-logs/directory/pull-ci-openshift-console-master-backend
The bug is fixed.
Comment 6 errata-xmlrpc 2021-02-24 15:31:24 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633
Note You need to log in before you can comment on or make changes to this bug.