Bug 189493 - [PATCH] off by one in pbs_sched
Summary: [PATCH] off by one in pbs_sched
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: torque
Version: 4
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Garrick Staples
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-04-20 14:58 UTC by Fabrice Bellet
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version: 2.1.0p0-0.10.200604211036cvs
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-04-21 17:17:39 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Fabrice Bellet 2006-04-20 14:58:49 UTC
this patch fixes a trivial problem in pbs_sched when counting the number of
chars written to its lock file. This error prevents this daemon from starting up.


--- torque-2.1.0p0-snap.200604171430/src/scheduler.cc/pbs_sched.c.orig 
2006-04-06 23:56:37.000000000 +0200
+++ torque-2.1.0p0-snap.200604171430/src/scheduler.cc/pbs_sched.c      
2006-04-20 16:52:38.000000000 +0200
@@ -992,7 +992,7 @@

         (void)sprintf(log_buffer, "%ld\n", (long)pid);

-        if (write(lockfds, log_buffer, strlen(log_buffer)+1) != strlen(log_buffer))
+        if (write(lockfds, log_buffer, strlen(log_buffer)+1) !=
strlen(log_buffer)+1)
           {
           perror("writing to lockfile");

Comment 1 Garrick Staples 2006-04-20 16:49:32 UTC
That's impressive.  TORQUE has been in FE for 1 day!

I'll get this upstream and probably have a new package tomorrow.

Thanks for the patch!


Note You need to log in before you can comment on or make changes to this bug.