- You need to set the arch info (isa)

Requires:	%{name}-libs%{?_isa} = %{version}-%{release}

 - Be more specific:

%{_includedir}/*

 - Source is 404:

404 Client Error: Not Found for url: https://codeload.github.com/KhronosGroup/OpenXR-SDK-Source/tar.gz/OpenXR-SDK-Source-release-1.0.12


 Should be 

Source:		https://github.com/KhronosGroup/%{pkgname}/releases/download/release-%{version}/%{pkgname}-release-%{version}.tar.gz


 - Build fails and I don't know why:

[ 65%] Building CXX object src/tests/list/CMakeFiles/openxr_runtime_list.dir/list.cpp.o
gmake[2]: Leaving directory '/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/x86_64-redhat-linux-gnu'
/usr/bin/gmake  -f src/tests/loader_test/CMakeFiles/loader_test.dir/build.make src/tests/loader_test/CMakeFiles/loader_test.dir/build
cd /builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/x86_64-redhat-linux-gnu/src/tests/list && /usr/lib64/ccache/g++ -DOPENXR_HAVE_COMMON_CONFIG -DXR_OS_LINUX -DXR_USE_GRAPHICS_API_OPENGL -DXR_USE_GRAPHICS_API_VULKAN -DXR_USE_PLATFORM_XLIB -DXR_USE_TIMESPEC -I/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/src/../include -I/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/src -I/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/src/common -I/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/x86_64-redhat-linux-gnu/include -I/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/external/include -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -Wl,--as-needed -Wall -Werror=unused-parameter -Wpointer-arith -fPIE -std=gnu++14 -o CMakeFiles/openxr_runtime_list.dir/list.cpp.o -c /builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/src/tests/list/list.cpp
gmake[2]: Entering directory '/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/x86_64-redhat-linux-gnu'
gmake[2]: *** No rule to make target '../GL', needed by 'src/tests/loader_test/loader_test'.  Stop.
gmake[2]: *** Waiting for unfinished jobs....


[ 90%] Building CXX object src/tests/hello_xr/CMakeFiles/hello_xr.dir/platformplugin_factory.cpp.o
cd /builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/x86_64-redhat-linux-gnu/src/tests/hello_xr && /usr/lib64/ccache/g++ -DOPENXR_HAVE_COMMON_CONFIG -DOS_LINUX_XLIB -DUSE_GLSLANGVALIDATOR -DXR_OS_LINUX -DXR_USE_GRAPHICS_API_OPENGL -DXR_USE_GRAPHICS_API_VULKAN -DXR_USE_PLATFORM_XLIB -DXR_USE_TIMESPEC -I/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/src/../include -I/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/src -I/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/x86_64-redhat-linux-gnu/src/tests/hello_xr -I/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/src/common -I/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/include -I/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/x86_64-redhat-linux-gnu/include -I/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/external/include -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -Wl,--as-needed -Wall -Werror=unused-parameter -Wpointer-arith -fPIE -std=gnu++14 -o CMakeFiles/hello_xr.dir/platformplugin_factory.cpp.o -c /builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/src/tests/hello_xr/platformplugin_factory.cpp
gmake[2]: *** No rule to make target '../GL', needed by 'src/tests/hello_xr/hello_xr'.  Stop.
gmake[2]: *** Waiting for unfinished jobs....


[ 93%] Building CXX object src/tests/hello_xr/CMakeFiles/hello_xr.dir/platformplugin_xlib.cpp.o
cd /builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/x86_64-redhat-linux-gnu/src/tests/hello_xr && /usr/lib64/ccache/g++ -DOPENXR_HAVE_COMMON_CONFIG -DOS_LINUX_XLIB -DUSE_GLSLANGVALIDATOR -DXR_OS_LINUX -DXR_USE_GRAPHICS_API_OPENGL -DXR_USE_GRAPHICS_API_VULKAN -DXR_USE_PLATFORM_XLIB -DXR_USE_TIMESPEC -I/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/src/../include -I/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/src -I/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/x86_64-redhat-linux-gnu/src/tests/hello_xr -I/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/src/common -I/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/include -I/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/x86_64-redhat-linux-gnu/include -I/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/external/include -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -Wl,--as-needed -Wall -Werror=unused-parameter -Wpointer-arith -fPIE -std=gnu++14 -o CMakeFiles/hello_xr.dir/platformplugin_xlib.cpp.o -c /builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/src/tests/hello_xr/platformplugin_xlib.cpp
gmake[2]: Leaving directory '/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/x86_64-redhat-linux-gnu'
gmake[1]: *** [CMakeFiles/Makefile2:635: src/tests/loader_test/CMakeFiles/loader_test.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....
gmake[2]: Leaving directory '/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/x86_64-redhat-linux-gnu'
gmake[1]: *** [CMakeFiles/Makefile2:604: src/tests/hello_xr/CMakeFiles/hello_xr.dir/all] Error 2


gmake[2]: Leaving directory '/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/x86_64-redhat-linux-gnu'
[ 96%] Built target XrApiLayer_api_dump
gmake[1]: Leaving directory '/builddir/build/BUILD/OpenXR-SDK-Source-release-1.0.12/x86_64-redhat-linux-gnu'
gmake: *** [Makefile:152: all] Error 2

(In reply to Robert-André Mauchin 🐧 from comment #1)
>  - You need to set the arch info (isa)
> 
> Requires:	%{name}-libs%{?_isa} = %{version}-%{release}

Fixed

> 
>  - Be more specific:
> 
> %{_includedir}/*
> 
>  - Source is 404:
> 
> 404 Client Error: Not Found for url:
> https://codeload.github.com/KhronosGroup/OpenXR-SDK-Source/tar.gz/OpenXR-SDK-
> Source-release-1.0.12
> 
> 
>  Should be 
> 
> Source:	
> https://github.com/KhronosGroup/%{pkgname}/releases/download/release-
> %{version}/%{pkgname}-release-%{version}.tar.gz

Fixed.
> 
> 
>  - Build fails and I don't know why:
> 
> [ 65%] Building CXX object
>> gmake[2]: *** No rule to make target '../GL', needed by
> 'src/tests/loader_test/loader_test'.  Stop.
> gmake[2]: *** Waiting for unfinished jobs....
> 

One of cmake command caused the issue so it is removed.
Updated:

SPEC: https://download.copr.fedorainfracloud.org/results/luya/blender-egl/fedora-rawhide-x86_64/01749765-openxr/openxr.spec
SRPM: https://download.copr.fedorainfracloud.org/results/luya/blender-egl/fedora-rawhide-x86_64/01749765-openxr/openxr-1.0.12-2.fc34.src.rpm

 - Space instead of tab line 14:

BuildRequires:	gcc-c++

 - You need to own these directories:

[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib64/cmake/openxr, /usr/include/openxr

Maybe remove the globs you've put and install the whole dir instead


 - Still SONAME issue:

openxr-devel.x86_64: E: invalid-soname /usr/lib64/libXrApiLayer_api_dump.so libXrApiLayer_api_dump.so
openxr-devel.x86_64: E: invalid-soname /usr/lib64/libXrApiLayer_core_validation.so libXrApiLayer_core_validation.so

File a bug upstream for these. Try fixing it yourself like for the other bug meanwhile.

src/api_layers/CMakeLists.txt

in

    # Linux api_dump-specific information
    set_target_properties(XrApiLayer_api_dump PROPERTIES LINK_FLAGS "-Wl,-Bsymbolic,--exclude-libs,ALL")

    # Linux core_validation-specific information
    set_target_properties(XrApiLayer_core_validation PROPERTIES LINK_FLAGS "-Wl,-Bsymbolic,--exclude-libs,ALL")

You can probably set soversion to 0 for now as it has not yet been versioned.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Apache License 2.0", "*No copyright*
     Apache License 2.0", "BSD 3-clause "New" or "Revised" License", "*No
     copyright* Boost Software License 1.0", "Creative Commons Attribution
     4.0 International License", "*No copyright* Creative Commons CC0
     Universal 1.0 Public Domain Dedication", "*No copyright* Khronos
     License", "Expat License", "SIL Open Font License 1.1", "the
     Unlicense", "Boost Software License 1.0", "Khronos License", "*No
     copyright* Expat License". 407 files have unknown license. Detailed
     output of licensecheck in /home/bob/packaging/review/openxr/review-
     openxr/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib64/cmake/openxr, /usr/include/openxr
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 61440 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in openxr-
     libs , openxr-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: openxr-1.0.12-2.fc34.x86_64.rpm
          openxr-libs-1.0.12-2.fc34.x86_64.rpm
          openxr-devel-1.0.12-2.fc34.x86_64.rpm
          openxr-debuginfo-1.0.12-2.fc34.x86_64.rpm
          openxr-debugsource-1.0.12-2.fc34.x86_64.rpm
          openxr-1.0.12-2.fc34.src.rpm
openxr-libs.x86_64: W: no-documentation
openxr-devel.x86_64: E: invalid-soname /usr/lib64/libXrApiLayer_api_dump.so libXrApiLayer_api_dump.so
openxr-devel.x86_64: E: invalid-soname /usr/lib64/libXrApiLayer_core_validation.so libXrApiLayer_core_validation.so
openxr-devel.x86_64: W: no-documentation
openxr.src:14: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 1)
6 packages and 0 specfiles checked; 2 errors, 3 warnings.

(In reply to Robert-André Mauchin 🐧 from comment #3)
>  - Space instead of tab line 14:
> 
> BuildRequires:	gcc-c++
> 

Fixed.

>  - You need to own these directories:
> 
> [!]: Package requires other packages for directories it uses.
>      Note: No known owner of /usr/lib64/cmake/openxr, /usr/include/openxr
> 
> Maybe remove the globs you've put and install the whole dir instead
> 

Fixed.


>  - Still SONAME issue:
> 
> openxr-devel.x86_64: E: invalid-soname /usr/lib64/libXrApiLayer_api_dump.so
> libXrApiLayer_api_dump.so
> openxr-devel.x86_64: E: invalid-soname
> /usr/lib64/libXrApiLayer_core_validation.so libXrApiLayer_core_validation.so
> 
> File a bug upstream for these. Try fixing it yourself like for the other bug
> meanwhile.
> 
> src/api_layers/CMakeLists.txt
> 

Fixed.


Updated 
SPEC: https://download.copr.fedorainfracloud.org/results/luya/blender-egl/fedora-rawhide-x86_64/01749998-openxr/openxr.spec
SRPM: https://download.copr.fedorainfracloud.org/results/luya/blender-egl/fedora-rawhide-x86_64/01749998-openxr/openxr-1.0.12-2.fc34.src.rpm

How did you fix the SO versioning, I see no patch addressing it?

Same with owning the directories:

%{_includedir}/%{name}/*.h
%{_libdir}/cmake/%{name}/*.cmake

Still not fixed.

Have you posted the correct spec?

Whoops, that was the wrong files. Here is the actual version
SPEC: https://download.copr.fedorainfracloud.org/results/luya/blender-egl/fedora-rawhide-x86_64/01751667-openxr/openxr.spec
SRPM: https://download.copr.fedorainfracloud.org/results/luya/blender-egl/fedora-rawhide-x86_64/01751667-openxr/openxr-1.0.12-3.fc34.src.rpm

 - This is not used in Fedora:

Group:		Graphics/3D


Package approved.

Thank you. I'll remove the Group tag which is the remain on Mageia spec file.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/openxr