Spec URL: http://dl.kwizart.net/review/bcd.spec SRPM URL: http://dl.kwizart.net/review/bcd-1.1-1.20180610gitd94c9fa.fc31.src.rpm Description: Bayesian Collaborative Denoiser for Monte-Carlo Rendering Fedora Account System Username: kwizart Koji scratch build for f34: https://koji.fedoraproject.org/koji/taskinfo?taskID=55104403 This package is needed for LuxRender as it's currently bundled into. rpmlint shows shared-lib-calls-exit and is reported at https://github.com/superboubek/bcd/issues/13 But I'm reluctant to patch before any upstream fix.
- Please document the patches, add a comment explaining why they are needed. Patch0: bcd-nodeps.patch Patch1: bcd-gcc.patch Patch2: bcd-eigen3.patch Patch3: bcd-links.patch Patch4: bcd-cuda.patch Patch5: bcd-json.patch - Not needed anymore: %ldconfig_scriptlets - In order to avoid unintentional soname bump, we recommend not globbing the major soname version, be more specific instead: %{_libdir}/*.so.0* - Be more specific here: %{_includedir}/bcd - Add this license to the list and add a comment explaining the license breakdown: GNU Affero General Public License v3.0 or later ----------------------------------------------- bcd-d94c9fa77c11afe7d04670d92b3930c417e19f4b/src/io/exr/io_exr.cpp bcd-d94c9fa77c11afe7d04670d92b3930c417e19f4b/src/io/exr/io_exr.h Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-clause "New" or "Revised" License", "GNU Affero General Public License v3.0 or later". 56 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/bcd/review-bcd/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: bcd-1.1-1.20180610gitd94c9fa.fc34.x86_64.rpm bcd-cli-1.1-1.20180610gitd94c9fa.fc34.x86_64.rpm bcd-devel-1.1-1.20180610gitd94c9fa.fc34.x86_64.rpm bcd-debuginfo-1.1-1.20180610gitd94c9fa.fc34.x86_64.rpm bcd-debugsource-1.1-1.20180610gitd94c9fa.fc34.x86_64.rpm bcd-1.1-1.20180610gitd94c9fa.fc34.src.rpm bcd.x86_64: W: spelling-error %description -l en_US denoise -> noise bcd.x86_64: W: spelling-error %description -l en_US covariance -> co variance, co-variance, variance bcd.x86_64: W: spelling-error %description -l en_US renderfarm -> render farm, render-farm, endearment bcd.x86_64: W: spelling-error %description -l en_US renderer -> tenderer, rendered, render bcd.x86_64: W: spelling-error %description -l en_US denoising -> denouncing bcd.x86_64: W: spelling-error %description -l en_US invasiveness -> evasiveness, pervasiveness, inventiveness bcd.x86_64: W: spelling-error %description -l en_US spp -> app, sop, pp bcd.x86_64: W: spelling-error %description -l en_US denoised -> noised bcd.x86_64: W: shared-lib-calls-exit /usr/lib64/libbcdio.so.0.0.0 exit.5 bcd-cli.x86_64: W: no-documentation bcd-cli.x86_64: W: no-manual-page-for-binary bcd-cli bcd-cli.x86_64: W: no-manual-page-for-binary bcd-raw-converter bcd-devel.x86_64: W: no-documentation bcd.src: W: spelling-error %description -l en_US denoise -> noise bcd.src: W: spelling-error %description -l en_US covariance -> co variance, co-variance, variance bcd.src: W: spelling-error %description -l en_US renderfarm -> render farm, render-farm, endearment bcd.src: W: spelling-error %description -l en_US renderer -> tenderer, rendered, render bcd.src: W: spelling-error %description -l en_US denoising -> denouncing bcd.src: W: spelling-error %description -l en_US invasiveness -> evasiveness, pervasiveness, inventiveness bcd.src: W: spelling-error %description -l en_US spp -> app, sop, pp bcd.src: W: spelling-error %description -l en_US denoised -> noised bcd.src:98: E: hardcoded-library-path in %{_prefix}/lib 6 packages and 0 specfiles checked; 1 errors, 21 warnings.
Spec URL: http://dl.kwizart.net/review/bcd.spec SRPM URL: http://dl.kwizart.net/review/bcd-1.1-2.20180610gitd94c9fa.fc31.src.rpm Description: Bayesian Collaborative Denoiser for Monte-Carlo Rendering Changelog: - Improve patch description - Enforce soversion - Mention AGPLv3+
- You need to explain he license breakdown n a comment # BSD: main program # AGPLv3+: src/io/exr License: BSD and AGPLv3+ Package approved. Please fix the aforementioned issue before import.
(In reply to Robert-André Mauchin 🐧 from comment #3) > - You need to explain he license breakdown n a comment I think I've done that before Source0, but I will pick your notation. Thanks for the review.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/bcd