Spec URL: https://fedorapeople.org/~whot/xkbcomp.spec SRPM URL: https://fedorapeople.org/~whot/xkbcomp-1.4.4-1.fc33.src.rpm Description: X.Org XKB keymap compiler Fedora Account System Username: whot Note: this is package split. xkbcomp has been in xorg-x11-xkb-utils forever, that package is split up into individual packages for its components. See https://fedoraproject.org/wiki/Changes/XorgUtilityDeaggregation for details
Problems: - devel sub-package should Requires: %{name}%{?_isa} = %{version}-%{release} rather than Requires: xkbcomp - Consider adding gpg check since upstream provides signature file ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "FSF All Permissive License", "NTP License (legal disclaimer)", "NTP License (legal disclaimer) [generated file]", "FSF Unlimited License (with Retention) GNU General Public License v2.0 or later [generated file]", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v3.0 or later", "FSF Unlimited License [generated file]", "Expat License [generated file]", "[generated file]". 39 files have unknown license. Detailed output of licensecheck in /home/yan/review/1895770-xkbcomp/licensecheck.txt NTP license is MIT license, and xkbcomp-1.4.4/xkbparse.c have a expection, which is fine to leave License column as MIT [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in xkbcomp- devel I think we need to fix this [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. Upstream provides .sig file, see https://www.x.org/archive/individual/app/xkbcomp-1.4.4.tar.bz2.sig [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. verified by koji scratch build. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: xkbcomp-1.4.4-1.fc34.x86_64.rpm xkbcomp-devel-1.4.4-1.fc34.x86_64.rpm xkbcomp-debuginfo-1.4.4-1.fc34.x86_64.rpm xkbcomp-debugsource-1.4.4-1.fc34.x86_64.rpm xkbcomp-1.4.4-1.fc34.src.rpm xkbcomp.x86_64: W: spelling-error Summary(en_US) keymap -> key map, key-map, mapmaker xkbcomp.x86_64: W: spelling-error %description -l en_US keymap -> key map, key-map, mapmaker xkbcomp.x86_64: W: obsolete-not-provided xorg-x11-xkb-utils Other packages will be changed to this, see: https://src.fedoraproject.org/rpms/bicon/c/24ab53807cc0f91edff72a86a2dc8c0aed9e59a9?branch=master xkbcomp-devel.x86_64: W: spelling-error Summary(en_US) keymap -> key map, key-map, mapmaker xkbcomp-devel.x86_64: W: spelling-error %description -l en_US keymap -> key map, key-map, mapmaker xkbcomp-devel.x86_64: W: no-documentation xkbcomp.src: W: spelling-error Summary(en_US) keymap -> key map, key-map, mapmaker xkbcomp.src: W: spelling-error %description -l en_US keymap -> key map, key-map, mapmaker 5 packages and 0 specfiles checked; 0 errors, 8 warnings. Rpmlint (debuginfo) ------------------- Checking: xkbcomp-debuginfo-1.4.4-1.fc34.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- xkbcomp-debuginfo.x86_64: W: invalid-url URL: https://www.x.org <urlopen error [Errno -3] Temporary failure in name resolution> xkbcomp.x86_64: W: spelling-error Summary(en_US) keymap -> key map, key-map, mapmaker xkbcomp.x86_64: W: spelling-error %description -l en_US keymap -> key map, key-map, mapmaker xkbcomp.x86_64: W: invalid-url URL: https://www.x.org <urlopen error [Errno -3] Temporary failure in name resolution> xkbcomp.x86_64: W: obsolete-not-provided xorg-x11-xkb-utils xkbcomp-devel.x86_64: W: spelling-error Summary(en_US) keymap -> key map, key-map, mapmaker xkbcomp-devel.x86_64: W: spelling-error %description -l en_US keymap -> key map, key-map, mapmaker xkbcomp-devel.x86_64: W: invalid-url URL: https://www.x.org <urlopen error [Errno -3] Temporary failure in name resolution> xkbcomp-devel.x86_64: W: no-documentation xkbcomp-debugsource.x86_64: W: invalid-url URL: https://www.x.org <urlopen error [Errno -3] Temporary failure in name resolution> 4 packages and 0 specfiles checked; 0 errors, 10 warnings. Source checksums ---------------- https://www.x.org/pub/individual/app/xkbcomp-1.4.4.tar.bz2 : CHECKSUM(SHA256) this package : 59cce603a607a17722a0a1cf99010f4894e7812beb5d695abbc08474d59af27e CHECKSUM(SHA256) upstream package : 59cce603a607a17722a0a1cf99010f4894e7812beb5d695abbc08474d59af27e Requires -------- xkbcomp (rpmlib, GLIBC filtered): libX11.so.6()(64bit) libc.so.6()(64bit) libxkbfile.so.1()(64bit) rtld(GNU_HASH) xkbcomp-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config pkgconfig xkbcomp xkbcomp-debuginfo (rpmlib, GLIBC filtered): xkbcomp-debugsource (rpmlib, GLIBC filtered): Provides -------- xkbcomp: xkbcomp xkbcomp(x86-64) xkbcomp-devel: pkgconfig(xkbcomp) xkbcomp-devel xkbcomp-devel(x86-64) xkbcomp-debuginfo: debuginfo(build-id) xkbcomp-debuginfo xkbcomp-debuginfo(x86-64) xkbcomp-debugsource: xkbcomp-debugsource xkbcomp-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1895770 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: PHP, Haskell, Ocaml, SugarActivity, Java, Python, fonts, Perl, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
And one more thing I forget to mention, please add BuildRequires: gcc since compiling this need gcc.
Thanks heaps, I've addressed two of the three issues: - Requires: in devel subpackage - fixed as requested - BuildRequires: gcc - added - also added %make_build/%make_install as requested in bug 1895795 gpg signature check was *NOT* added. there is a signature upstream but it is signed by whoever does the releases. There is no fixed upstream maintainer either, so we'd have to juggle the gpg keyrings with every release. Updated files available at the same URLs: Spec URL: https://fedorapeople.org/~whot/xkbcomp.spec SRPM URL: https://fedorapeople.org/~whot/xkbcomp-1.4.4-1.fc33.src.rpm
LGTM, Approved. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "FSF All Permissive License", "NTP License (legal disclaimer)", "NTP License (legal disclaimer) [generated file]", "FSF Unlimited License (with Retention) GNU General Public License v2.0 or later [generated file]", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v3.0 or later", "FSF Unlimited License [generated file]", "Expat License [generated file]", "[generated file]". 39 files have unknown license. Detailed output of licensecheck in /home/yan/review/1895770-xkbcomp/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. Upstream don't use a fixed signature. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: xkbcomp-1.4.4-1.fc34.x86_64.rpm xkbcomp-devel-1.4.4-1.fc34.x86_64.rpm xkbcomp-debuginfo-1.4.4-1.fc34.x86_64.rpm xkbcomp-debugsource-1.4.4-1.fc34.x86_64.rpm xkbcomp-1.4.4-1.fc34.src.rpm xkbcomp.x86_64: W: spelling-error Summary(en_US) keymap -> key map, key-map, mapmaker xkbcomp.x86_64: W: spelling-error %description -l en_US keymap -> key map, key-map, mapmaker xkbcomp.x86_64: W: obsolete-not-provided xorg-x11-xkb-utils xkbcomp-devel.x86_64: W: spelling-error Summary(en_US) keymap -> key map, key-map, mapmaker xkbcomp-devel.x86_64: W: spelling-error %description -l en_US keymap -> key map, key-map, mapmaker xkbcomp-devel.x86_64: W: no-documentation xkbcomp.src: W: spelling-error Summary(en_US) keymap -> key map, key-map, mapmaker xkbcomp.src: W: spelling-error %description -l en_US keymap -> key map, key-map, mapmaker 5 packages and 0 specfiles checked; 0 errors, 8 warnings. Rpmlint (debuginfo) ------------------- Checking: xkbcomp-debuginfo-1.4.4-1.fc34.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- xkbcomp.x86_64: W: spelling-error Summary(en_US) keymap -> key map, key-map, mapmaker xkbcomp.x86_64: W: spelling-error %description -l en_US keymap -> key map, key-map, mapmaker xkbcomp.x86_64: W: invalid-url URL: https://www.x.org <urlopen error [Errno -3] Temporary failure in name resolution> xkbcomp.x86_64: W: obsolete-not-provided xorg-x11-xkb-utils xkbcomp-debugsource.x86_64: W: invalid-url URL: https://www.x.org <urlopen error [Errno -3] Temporary failure in name resolution> xkbcomp-debuginfo.x86_64: W: invalid-url URL: https://www.x.org <urlopen error [Errno -3] Temporary failure in name resolution> xkbcomp-devel.x86_64: W: spelling-error Summary(en_US) keymap -> key map, key-map, mapmaker xkbcomp-devel.x86_64: W: spelling-error %description -l en_US keymap -> key map, key-map, mapmaker xkbcomp-devel.x86_64: W: invalid-url URL: https://www.x.org <urlopen error [Errno -3] Temporary failure in name resolution> xkbcomp-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 10 warnings. Source checksums ---------------- https://www.x.org/pub/individual/app/xkbcomp-1.4.4.tar.bz2 : CHECKSUM(SHA256) this package : 59cce603a607a17722a0a1cf99010f4894e7812beb5d695abbc08474d59af27e CHECKSUM(SHA256) upstream package : 59cce603a607a17722a0a1cf99010f4894e7812beb5d695abbc08474d59af27e Requires -------- xkbcomp (rpmlib, GLIBC filtered): libX11.so.6()(64bit) libc.so.6()(64bit) libxkbfile.so.1()(64bit) rtld(GNU_HASH) xkbcomp-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config pkgconfig xkbcomp(x86-64) xkbcomp-debuginfo (rpmlib, GLIBC filtered): xkbcomp-debugsource (rpmlib, GLIBC filtered): Provides -------- xkbcomp: xkbcomp xkbcomp(x86-64) xkbcomp-devel: pkgconfig(xkbcomp) xkbcomp-devel xkbcomp-devel(x86-64) xkbcomp-debuginfo: debuginfo(build-id) xkbcomp-debuginfo xkbcomp-debuginfo(x86-64) xkbcomp-debugsource: xkbcomp-debugsource xkbcomp-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1895770 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Haskell, Java, Ocaml, fonts, Perl, SugarActivity, PHP, R, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/xkbcomp
xkbcomp-1.4.4-1.fc34 is available in rawhide, thanks everyone