Spec URL: https://smani.fedorapeople.org/review/mingw-python-psycopg2.spec SRPM URL: mingw-python-psycopg2-2.8.6-1.fc34.src.rpm Description: MinGW Windows Python psycopg2 library Fedora Account System Username: smani Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=55265832
Spec URL: https://smani.fedorapeople.org/review/mingw-python-psycopg2.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-python-psycopg2-2.8.6-1.fc34.src.rpm Description: MinGW Windows Python psycopg2 library Fedora Account System Username: smani Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=55265832
I will take this review.
And issue Nr 1 will be the incorrect URL... Ups...
I will assume you have that covered, then. :-)
Pretend you're reading as follows :) %global pypi_name %{pkgname} ... URL: https://www.psycopg.org/ Source0: %{pypi_source}
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - The LICENSE file claims the license is LGPLv3+, not BSD. The BSD-like license (which licensecheck identifies as "zlib/libpng") only applies to psycopg/adapter*.{h,c} and psycopg/microprotocol*.{h,c}. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* zlib/libpng license GNU Lesser General Public License v3.0 or later", "*No copyright* GNU Lesser General Public License", "GNU Lesser General Public License v3.0 or later", "GNU Lesser General Public License, Version 3", "Public domain", "Python Software Foundation License version 2 GNU Lesser General Public License v3.0 or later". 52 files have unknown license. Detailed output of licensecheck in /home/jamesjer/1896179-mingw-python-psycopg2/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mingw32-python3-psycopg2-2.8.6-1.fc34.noarch.rpm mingw64-python3-psycopg2-2.8.6-1.fc34.noarch.rpm mingw-python-psycopg2-2.8.6-1.fc34.src.rpm mingw32-python3-psycopg2.noarch: W: no-documentation mingw32-python3-psycopg2.noarch: W: non-standard-dir-in-usr i686-w64-mingw32 mingw64-python3-psycopg2.noarch: W: no-documentation mingw64-python3-psycopg2.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32 3 packages and 0 specfiles checked; 0 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- mingw32-python3-psycopg2.noarch: W: no-documentation mingw64-python3-psycopg2.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- http://initd.org/psycopg/tarballs/PSYCOPG-2-8/psycopg2-2.8.6.tar.gz : CHECKSUM(SHA256) this package : fb23f6c71107c37fd667cb4ea363ddeb936b348bbd6449278eb92c189699f543 CHECKSUM(SHA256) upstream package : fb23f6c71107c37fd667cb4ea363ddeb936b348bbd6449278eb92c189699f543 Requires -------- mingw32-python3-psycopg2 (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(libgcc_s_dw2-1.dll) mingw32(libpq.dll) mingw32(libpython3.9.dll) mingw32(libssp-0.dll) mingw32(libwinpthread-1.dll) mingw32(msvcrt.dll) mingw32(ws2_32.dll) mingw32-crt mingw32-filesystem mingw64-python3-psycopg2 (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(libpq.dll) mingw64(libpython3.9.dll) mingw64(libssp-0.dll) mingw64(libwinpthread-1.dll) mingw64(msvcrt.dll) mingw64(ws2_32.dll) mingw64-crt mingw64-filesystem Provides -------- mingw32-python3-psycopg2: mingw32(_psycopg-cpython-39.dll) mingw32-python3-psycopg2 mingw64-python3-psycopg2: mingw64(_psycopg-cpython-39.dll) mingw64-python3-psycopg2 Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -b 1896179 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, Generic Disabled plugins: R, Ruby, Ocaml, Java, SugarActivity, Perl, C/C++, Haskell, PHP, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Someone should pay attention when copying other specfiles... Spec URL: https://smani.fedorapeople.org/review/mingw-python-psycopg2.spec SRPM URL: https://smani.fedorapeople.org/review/mingw-python-psycopg2-2.8.6-2.fc34.src.rpm %changelog * Thu Nov 09 2020 Sandro Mani <manisandro> - 2.8.6-2 - Fix License and URL, use pypi_source
Looks good, APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-python-psycopg2
Thanks, I owe you some reviews!