Spec URL: https://yanqiyu.fedorapeople.org/ddcutil/ddcutil.spec SRPM URL: https://yanqiyu.fedorapeople.org/ddcutil/ddcutil-0.9.9-3.fc33.src.rpm Description: Query and change monitor settings Fedora Account System Username: yanqiyu
> %package -n libddcutil3 In Fedora version suffixes are only used when you need to have multiple versions of the package installable simultaneously. Upstream spec file probably does that to comply with openSUSE packaging guidelines which conflict with Fedora's. > %if %{with build_lib} > %ldconfig_scriptlets -n libddcutil3 > %endif That's something you'll only ever need for epel7. Anything newer (including el8) defines %ldconfig_scriptlets as noop. > Requires: ... There's a few more utils that are invoked via execute_shell_cmd/execute_shell_cmd_rpt, but most of them are not required. Would be nice to review this list and add Recommends for those that are significantly improving ddcutil output and usability.
Change to suggestions
More nitpicking after running fedora-review: > [ ]: License field in the package spec file matches the actual license. Surprisingly, FindDDCUtils.cmake has BSD license header. libddcutil-devel license tag should reflect that. The rest of licensecheck output is a noise from autotools and generated code. > [ ]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/lib64/cmake Please, add `Requires: cmake-filesystem%{?_isa}` to devel package (adding `BuildRequires: cmake` would achieve the same effect with more magic involved). > ddcutil.x86_64: W: spurious-executable-perm /usr/share/doc/ddcutil/ChangeLog > ddcutil.x86_64: W: spurious-executable-perm /usr/share/doc/ddcutil/NEWS.md Don't know if it's worth fixing, but simple chmod in %prep could take care of that. i2c-tools has `ExcludeArch: s390 s390x`. Feel free to do the same, with a comment explaining why ExcludeArch is needed. Does libddcutil have the same set of runtime dependencies? If it is then it should list all of them for the case where the library is used without the main package. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "[generated file]", "FSF Unlimited License (with Retention) GNU General Public License v2.0 or later [generated file]", "FSF Unlimited License [generated file]", "GNU General Public License v2.0 or later", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v3.0 or later", "Expat License [generated file]", "FSF Unlimited License (with Retention)", "FSF Unlimited License (with Retention) GNU General Public License, Version 2", "BSD 3-clause "New" or "Revised" License". 282 files have unknown license. Detailed output of licensecheck in /home/alebastr/rpmbuild/1896303-ddcutil/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/cmake [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 8 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libddcutil Not needed - library is independent from the binary package [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ddcutil-0.9.9-2.fc34.x86_64.rpm libddcutil-0.9.9-2.fc34.x86_64.rpm libddcutil-devel-0.9.9-2.fc34.x86_64.rpm ddcutil-debuginfo-0.9.9-2.fc34.x86_64.rpm ddcutil-debugsource-0.9.9-2.fc34.x86_64.rpm ddcutil-0.9.9-2.fc34.src.rpm ddcutil.x86_64: W: spurious-executable-perm /usr/share/doc/ddcutil/ChangeLog ddcutil.x86_64: W: spurious-executable-perm /usr/share/doc/ddcutil/NEWS.md libddcutil.x86_64: W: spelling-error %description -l en_US ddcutil -> ductile libddcutil.x86_64: W: spurious-executable-perm /usr/share/doc/libddcutil/ChangeLog libddcutil.x86_64: W: spurious-executable-perm /usr/share/doc/libddcutil/NEWS.md libddcutil-devel.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (debuginfo) ------------------- Checking: ddcutil-debuginfo-0.9.9-2.fc34.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- libddcutil-devel.x86_64: W: no-documentation libddcutil.x86_64: W: spelling-error %description -l en_US ddcutil -> ductile libddcutil.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libddcutil.so.3.0.0 /lib64/libz.so.1 libddcutil.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libddcutil.so.3.0.0 /lib64/libusb-1.0.so.0 libddcutil.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libddcutil.so.3.0.0 /lib64/libdl.so.2 libddcutil.x86_64: W: spurious-executable-perm /usr/share/doc/libddcutil/ChangeLog libddcutil.x86_64: W: spurious-executable-perm /usr/share/doc/libddcutil/NEWS.md ddcutil.x86_64: W: spurious-executable-perm /usr/share/doc/ddcutil/ChangeLog ddcutil.x86_64: W: spurious-executable-perm /usr/share/doc/ddcutil/NEWS.md 5 packages and 0 specfiles checked; 0 errors, 9 warnings.
(In reply to Aleksei Bavshin from comment #3) > More nitpicking after running fedora-review: > > > [ ]: License field in the package spec file matches the actual license. > > Surprisingly, FindDDCUtils.cmake has BSD license header. libddcutil-devel > license tag should reflect that. Changed. > The rest of licensecheck output is a noise from autotools and generated code. > > > [ ]: Package must own all directories that it creates. > > Note: Directories without known owners: /usr/lib64/cmake > > Please, add `Requires: cmake-filesystem%{?_isa}` to devel package (adding > `BuildRequires: cmake` would achieve the same effect with more magic > involved). Changed. > > > ddcutil.x86_64: W: spurious-executable-perm /usr/share/doc/ddcutil/ChangeLog > > ddcutil.x86_64: W: spurious-executable-perm /usr/share/doc/ddcutil/NEWS.md > > Don't know if it's worth fixing, but simple chmod in %prep could take care > of that. fixed. > > > i2c-tools has `ExcludeArch: s390 s390x`. Feel free to do the same, with a > comment explaining why ExcludeArch is needed. fixed. > > > Does libddcutil have the same set of runtime dependencies? It don't seem so.
Looks good, thanks for making all these changes :) Approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ddcutil
Built in rawhide