Bug 189673 - should not ship (unmodified) 'magick-config.h' file
Summary: should not ship (unmodified) 'magick-config.h' file
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: ImageMagick
Version: 5
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Norm Murray
QA Contact:
URL:
Whiteboard: bzcl34nup
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-04-22 14:00 UTC by Enrico Scholz
Modified: 2008-04-25 13:30 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-04-25 13:30:21 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Enrico Scholz 2006-04-22 14:00:02 UTC
Description of problem:

ImageMagick-devel ships a /usr/include/magick/magick-config.h file containing
lot of default autoconf stuff. E.g.

| #define HAVE_ASSERT_H 1
| #define HAVE_DLERROR 1
| #define PACKAGE_NAME "magick/magick.h"

When a program includes ImageMagick headers it include this magick-config.h file
too. Depending on compiler switches, the wrong macros might be defined resp.
will conflict with current ones.

E.g. when compile 'kismet', I get

| config.h:175:1: warning: "PACKAGE_BUGREPORT" redefined
| In file included from /usr/include/magick/ImageMagick.h:29,
|                  from /usr/include/magick/api.h:28,
|                  from gpsmap.cc:47:
| /usr/include/magick/magick-config.h:494:1: warning: this is the location of
the previous definition

The autoconf's 'config.h' files must never be shipped unmodified. I suggest to
remove magick-config.h file from the package and replace the used macros in the
shipped headers manually.



Version-Release number of selected component (if applicable):

ImageMagick-devel-6.2.5.4-4.2.1


How reproducible:

100%

Comment 1 Bug Zapper 2008-04-04 02:43:47 UTC
Fedora apologizes that these issues have not been resolved yet. We're
sorry it's taken so long for your bug to be properly triaged and acted
on. We appreciate the time you took to report this issue and want to
make sure no important bugs slip through the cracks.

If you're currently running a version of Fedora Core between 1 and 6,
please note that Fedora no longer maintains these releases. We strongly
encourage you to upgrade to a current Fedora release. In order to
refocus our efforts as a project we are flagging all of the open bugs
for releases which are no longer maintained and closing them.
http://fedoraproject.org/wiki/LifeCycle/EOL

If this bug is still open against Fedora Core 1 through 6, thirty days
from now, it will be closed 'WONTFIX'. If you can reporduce this bug in
the latest Fedora version, please change to the respective version. If
you are unable to do this, please add a comment to this bug requesting
the change.

Thanks for your help, and we apologize again that we haven't handled
these issues to this point.

The process we are following is outlined here:
http://fedoraproject.org/wiki/BugZappers/F9CleanUp

We will be following the process here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping to ensure this
doesn't happen again.

And if you'd like to join the bug triage team to help make things
better, check out http://fedoraproject.org/wiki/BugZappers

Comment 2 Hans de Goede 2008-04-25 13:30:21 UTC
Quick intro: I'm now a comaintainer of ImageMagick, and thus going through all
the open bugs.

magick-config.h now prefixes all its defines with MAGICKCORE_, closing.




Note You need to log in before you can comment on or make changes to this bug.