Bug 1897065 - VMware VM name containing a slash ("/") marked as a critical concern by a Validation service rule
Summary: VMware VM name containing a slash ("/") marked as a critical concern by a Val...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Migration Toolkit for Virtualization
Classification: Red Hat
Component: General
Version: 2.0.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
: 2.0.0
Assignee: Peter McGowan
QA Contact: Maayan Hadasi
Avital Pinnick
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-11-12 08:28 UTC by Ilanit Stein
Modified: 2021-06-10 17:11 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-10 17:11:26 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
mini-rhel7⁄mguetta (51.58 KB, image/png)
2021-04-20 07:51 UTC, Maayan Hadasi
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2021:2381 0 None None None 2021-06-10 17:11:39 UTC

Description Ilanit Stein 2020-11-12 08:28:33 UTC
Description of problem:
'/' is not allowed in OpenShift names.
The VM should be marked as critical concern by a validation service rule.

Comment 2 Fabien Dupont 2020-11-24 18:06:55 UTC
Discussions in progress about the validation service. Will revisit to assign to the right person.

Comment 3 Peter McGowan 2021-01-22 09:46:15 UTC
Test for this condition added in https://github.com/konveyor/forklift-validation/pull/7

Comment 4 Fabien Dupont 2021-03-31 06:43:42 UTC
This should be part of build 2.0.0-8 / iib:62459.

Comment 5 Maayan Hadasi 2021-04-20 07:51:28 UTC
Created attachment 1773675 [details]
mini-rhel7⁄mguetta

Comment 6 Maayan Hadasi 2021-04-20 07:53:24 UTC
@Fabien, @Peter
I am verifying this issue with MTV 2.0.0-17 / iib:66911 and the VM name contains '%2f' instead of '/' character of the original VM name (please see attached image)
Is it an expected behavior?

Comment 7 Fabien Dupont 2021-04-27 07:18:32 UTC
@mguetta this is not the expected behavior.
From the attached screenshot, I think this BZ can be marked VERIFIED, since the critical concern is present.

And I think there are 2 new bugs to open:

- The / character is escaped to %2f when displaying the VM name
- The new line is escaped in the concern message. It contains "\n" in the original message, so there should be more than one line.

Comment 8 Maayan Hadasi 2021-04-27 08:24:33 UTC
Thanks Fabien,

Regarding the new bugs:
1. I created this BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1953925
2. I am not sure what did you mean by "concern message" - Is it the first line where the VM is marked as Critical? Is this row should contain more than one line?
I am asking because the information that shows in the attached image seems to me very clear and I don't see the value of adding one more blank line
Thanks again

Comment 9 Fabien Dupont 2021-04-27 08:32:02 UTC
Thanks for the new BZ. The message is clear but the validation returns a multiline string, i.e. with "\n", so the UI should respect them. If we think that the message should be a single line, we need to change  it on the validation service side.

Comment 10 Maayan Hadasi 2021-04-27 08:58:58 UTC
(In reply to Fabien Dupont from comment #9)
> The message is clear but the validation returns a
> multiline string, i.e. with "\n", so the UI should respect them. If we think
> that the message should be a single line, we need to change  it on the
> validation service side.
Bug 1953938 - [MTV][UI] Missing a new line ('\n') in the VM's concern message in "Select VMs for migration" stage

Thanks for the clarification

Comment 11 Maayan Hadasi 2021-04-27 09:02:45 UTC
The issue is verified as fixed

VMware VM name with '/' is marked as critical concern

Comment 14 errata-xmlrpc 2021-06-10 17:11:26 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (MTV 2.0.0 images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:2381


Note You need to log in before you can comment on or make changes to this bug.