RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1897530 - [ppc64le] multipathd didn't report error when /etc/multipath.conf lack of }
Summary: [ppc64le] multipathd didn't report error when /etc/multipath.conf lack of }
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: device-mapper-multipath
Version: 8.4
Hardware: ppc64le
OS: Linux
high
high
Target Milestone: rc
: 8.0
Assignee: Ben Marzinski
QA Contact: Lin Li
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-11-13 11:17 UTC by Lin Li
Modified: 2021-09-06 15:21 UTC (History)
9 users (show)

Fixed In Version: device-mapper-multipath-0.8.4-6.el8
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-05-18 15:06:46 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Lin Li 2020-11-13 11:17:08 UTC 
Description of problem:
[ppc64le] multipathd  didn't report error when /etc/multipath.conf lack of }

Version-Release number of selected component (if applicable):
device-mapper-multipath-0.8.4-5.el8.ppc64le

How reproducible:
always

Steps to Reproduce:
1.[root@ibm-p9z-20-lp13 multipathd_commands]# rpm -qa | grep multipath
kernel-kernel-storage-multipath-multipathd_commands-1.0-5.noarch
device-mapper-multipath-libs-0.8.4-5.el8.ppc64le
device-mapper-multipath-0.8.4-5.el8.ppc64le
2. edit /etc/multipath.conf
[root@ibm-p9z-20-lp13 multipathd_commands]# cat /etc/multipath.conf 
defaults {
#	find_multipaths yes
	find_multipaths smart
	user_friendly_names yes
}


blacklist {
}



devices {
	device {
	vendor "^DGC"
		product "^(RAID|DISK|VRAID)"
		path_grouping_policy failover

	}
#}      <-----------------------------------------------

3.[root@ibm-p9z-20-lp13 multipathd_commands]# service multipathd reload
Redirecting to /bin/systemctl reload multipathd.service
[root@ibm-p9z-20-lp13 multipathd_commands]# echo $?
0

4.[root@ibm-p9z-20-lp13 multipathd_commands]# multipathd show config | grep -C 15 DGC
devices {
	device {
		vendor "^DGC"
		product "^(RAID|DISK|VRAID)"
		product_blacklist "LUNZ"
		path_grouping_policy "failover"
		path_checker "emc_clariion"
		hardware_handler "1 emc"
		prio "emc"
		failback "immediate"
		no_path_retry 60
	}
}


Actual results:
{} should appear in pairs. One } is missing, but multipathd does not report an error. The changes still take effect.

Expected results:
multipathd should report an error when {} in /etc/multipath.conf does not appear in pairs. 

Additional info:
This is a IBM ppc64le server. 
vendor = DGC
product = VRAID
Comment 1 Lin Li 2020-11-13 11:20:21 UTC 
Hi Ben,
I reserved a ppc64le server. You can login the server to check it ?
Hostname:ibm-p9z-20-lp13.fs.lab.eng.bos.redhat.com
password:redhat
Thanks in advance!
Comment 3 Ben Marzinski 2020-11-16 20:03:24 UTC 
Aa far as I recall, multipath has never reported an error if the final closing braces are missing, on any architecture.  But it does make sense to do so.
Comment 4 Ben Marzinski 2020-12-08 02:15:17 UTC 
Fixed.
Comment 7 Lin Li 2020-12-10 06:52:53 UTC 
Verified on device-mapper-multipath-0.8.4-6.el8.ppc64le
1,[root@ibm-p9z-20-lp15 ~]# rpm -qa | grep multipath
device-mapper-multipath-libs-0.8.4-6.el8.ppc64le
device-mapper-multipath-0.8.4-6.el8.ppc64le

2,edit /etc/multipath.conf
[root@ibm-p9z-20-lp15 ~]# cat /etc/multipath.conf 
defaults {
#	find_multipaths yes
	find_multipaths smart
	user_friendly_names yes
}


blacklist {
}

devices {
	device {
	vendor "^DGC"
		product "^(RAID|DISK|VRAID)"
		path_grouping_policy failover

	}
#}    <------------------------------------

3,[root@ibm-p9z-20-lp15 ~]# service multipathd reload
Redirecting to /bin/systemctl reload multipathd.service

4,[root@ibm-p9z-20-lp15 ~]# multipath -ll
Dec 10 01:45:36 | missing '}' at end of /etc/multipath.conf    <------------------------------------------------------
mpatha (3600601605e203f008e22d0221f07eb11) dm-0 DGC,VRAID
size=8.0G features='1 queue_if_no_path' hwhandler='1 alua' wp=rw
|-+- policy='service-time 0' prio=50 status=active
| `- 1:0:1:0 sdb 8:16 active ready running
|-+- policy='service-time 0' prio=10 status=enabled
| `- 1:0:0:0 sda 8:0  active ready running
|-+- policy='service-time 0' prio=10 status=enabled
| `- 2:0:0:0 sdc 8:32 active ready running
`-+- policy='service-time 0' prio=50 status=enabled
  `- 2:0:1:0 sdd 8:48 active ready running

5,[root@ibm-p9z-20-lp15 ~]# multipathd show config | grep -C 15 DGC
Dec 10 01:45:53 | missing '}' at end of /etc/multipath.conf  <------------------------------------------------------
	......
	device {
		vendor "^DGC"
		product "^(RAID|DISK|VRAID)"
		product_blacklist "LUNZ"
		path_grouping_policy "failover"
		path_checker "emc_clariion"
		hardware_handler "1 emc"
		prio "emc"
		failback "immediate"
		no_path_retry 60
	}
}



Test result:multipath and multipathd report error while missing '}' at end of /etc/multipath.conf
Comment 9 errata-xmlrpc 2021-05-18 15:06:46 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (device-mapper-multipath bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:1685
Note You need to log in before you can comment on or make changes to this bug.