Bug 1897619 - Review Request: rubygem-asciidoctor-diagram - Asciidoctor diagramming extension
Summary: Review Request: rubygem-asciidoctor-diagram - Asciidoctor diagramming extension
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jared Smith
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-11-13 16:22 UTC by Christopher Brown
Modified: 2021-09-02 15:46 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-09-02 15:46:55 UTC
Type: ---
Embargoed:
jsmith.fedora: fedora-review?


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github asciidoctor asciidoctor-diagram issues 314 0 None open Sources of the *.jar files 2021-01-01 22:13:53 UTC

Description Christopher Brown 2020-11-13 16:22:36 UTC
Spec URL: https://raw.githubusercontent.com/snecklifter/rubygem-asciidoctor-diagram/master/rubygem-asciidoctor-diagram.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/snecker/rubygem-asciidoctor-diagram/
Description: Asciidoctor Diagram is a set of Asciidoctor extensions that enables you to add diagrams, which you describe using plain text, to your AsciiDoc document.

Fedora Account System Username: snecker

Comment 1 Jared Smith 2020-11-25 14:17:44 UTC
The %check section appears to have some issues:

+ umask 022
+ cd /builddir/build/BUILD
+ cd asciidoctor-diagram-2.0.5
+ rspec -r asciidoctor-pdf --pattern spec/blockdiag_spec.rb --pattern spec/test_helper.rb --pattern spec/ditaa_spec.rb --pattern spec/msc_spec.rb --pattern spec/plantuml_spec.rb --pattern spec/gnuplot_spec.rb --pattern spec/meme_spec.rb --pattern spec/graphviz_spec.rb
An error occurred while loading asciidoctor-pdf.
Failure/Error: return gem_original_require(path)
LoadError:
  cannot load such file -- prawn/icon
# /usr/share/gems/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/ext/prawn/extensions.rb:5:in `<top (required)>'
# /usr/share/gems/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/ext/prawn.rb:9:in `require_relative'
# /usr/share/gems/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/ext/prawn.rb:9:in `<top (required)>'
# /usr/share/gems/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/ext.rb:6:in `require_relative'
# /usr/share/gems/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/ext.rb:6:in `<top (required)>'
# /usr/share/gems/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf.rb:13:in `require_relative'
# /usr/share/gems/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf.rb:13:in `<top (required)>'
# /usr/share/gems/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor-pdf.rb:3:in `require_relative'
# /usr/share/gems/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor-pdf.rb:3:in `<top (required)>'
# ------------------
# --- Caused by: ---
# LoadError:
#   cannot load such file -- asciidoctor-pdf
#   /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:83:in `require'
No examples found.
Finished in 0.00003 seconds (files took 0.15893 seconds to load)
0 examples, 0 failures, 1 error occurred outside of examples
error: Bad exit status from /var/tmp/rpm-tmp.uBBi4w (%check)

Comment 2 Christopher Brown 2020-11-26 14:11:57 UTC
Hi Jared,

(In reply to Jared Smith from comment #1)
> The %check section appears to have some issues:

Thanks, thats the original build. I'll update the comment.

https://copr-be.cloud.fedoraproject.org/results/snecker/rubygem-asciidoctor-diagram/

Comment 3 Christopher Brown 2020-12-07 17:34:28 UTC
Hi Jared, anything else that needs doing here?

Comment 4 Robert-André Mauchin 🐧 2020-12-22 12:49:24 UTC
Issues:
=======
- Bundled jar/class files should be removed before build
  Note: Jar files in source (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Java/#_pre_built_dependencies

Jar and class files in source
-----------------------------
./asciidoctor-diagram-2.0.5/lib/batik-all-1.10.jar
./asciidoctor-diagram-2.0.5/lib/ditaa-1.3.15.jar
./asciidoctor-diagram-2.0.5/lib/ditaamini-0.12.jar
./asciidoctor-diagram-2.0.5/lib/jlatexmath-minimal-1.0.5.jar
./asciidoctor-diagram-2.0.5/lib/plantuml-1.3.15.jar
./asciidoctor-diagram-2.0.5/lib/plantuml.jar
./asciidoctor-diagram-2.0.5/lib/server-1.3.15.jar

Comment 5 Christopher Brown 2020-12-22 15:57:44 UTC
Hi Robert-André

(In reply to Robert-André Mauchin 🐧 from comment #4)
> Issues:
> =======
> - Bundled jar/class files should be removed before build


Thanks! Have done so and updated copr build is complete along with spec file.

Comment 6 Robert-André Mauchin 🐧 2020-12-23 00:42:01 UTC
(In reply to Christopher Brown from comment #5)
> Hi Robert-André
> 
> (In reply to Robert-André Mauchin 🐧 from comment #4)
> > Issues:
> > =======
> > - Bundled jar/class files should be removed before build
> 
> 
> Thanks! Have done so and updated copr build is complete along with spec file.

You removed them but will the program still work without them??

Comment 7 Robert-André Mauchin 🐧 2020-12-23 07:00:29 UTC
This is wrong:

%prep
%setup -q -n %{gem_name}-%{version}
rm -f %{gem_libdir}/*.jar

In %prep the jar are not in %{gem_libdir} but in the lib/ subdirectory. Removing them in %prep prevents the build.

Comment 8 Fabio Valentini 2020-12-27 15:22:59 UTC
If you need to populate a lib/ directory with system-provided JAR files, look at the "build-jar-repository" command that's shipped with javapackages-tools.

Comment 9 Christopher Brown 2020-12-27 23:39:49 UTC
(In reply to Fabio Valentini from comment #8)
> If you need to populate a lib/ directory with system-provided JAR files,
> look at the "build-jar-repository" command that's shipped with
> javapackages-tools.

Thanks, thats helpful, will do. I think some of the jar files in the gem's lib/ directory can be replaced with those shipped by other packages but some cannot.

Robert-André has raised this at:

https://github.com/asciidoctor/asciidoctor-diagram/issues/314

and I can now successfully build those jar files using gradle following some fixes to the tests by the maintainer.

So the sources for the jar files appear to be located at:

https://github.com/pepijnve/ditaa
https://github.com/asciidoctor/asciidoctor-diagram-java

and I'm working my way through those to understand how to gather the required JARs.

Comment 10 Christopher Brown 2020-12-28 23:31:18 UTC
Ok, so the JAR files appear to be comprised as follows:

https://github.com/pepijnve/ditaa/releases/tag/mini-0.12
ditaamini-0.12.jar


https://github.com/asciidoctor/asciidoctor-diagram-java/tree/2c91454577f9614b619ad61b0e4e7252ef875f04 (no tag or release AFAICS)
ditaa-1.3.15.jar
jlatexmath-minimal-1.0.5.jar
plantuml-1.3.15.jar
server-1.3.15.jar 

PlantUML package
plantuml.jar

https://github.com/apache/xmlgraphics-batik/releases/tag/batik-1_10
batik-all-1.10.jar

Will now start pulling these together as separate source files.

Comment 11 Christopher Brown 2021-09-02 15:46:55 UTC
Abandoning, this is dependency hell and I don't have the time unfortunately.


Note You need to log in before you can comment on or make changes to this bug.