Bug 1897891 - [RFE][v2v][UI][CNV VM import] Providing error message or/and block migration when vddk-init-image is missing
Summary: [RFE][v2v][UI][CNV VM import] Providing error message or/and block migration ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Console Kubevirt Plugin
Version: 4.6
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ---
: 4.7.0
Assignee: Filip Krepinsky
QA Contact: Maayan Hadasi
URL:
Whiteboard:
: 1887482 (view as bug list)
Depends On: 1898070
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-11-15 11:10 UTC by Maayan Hadasi
Modified: 2021-02-24 15:33 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-02-24 15:33:27 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
ui_screenshot (55.21 KB, image/png)
2020-11-19 13:22 UTC, Maayan Hadasi
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2020:5633 0 None None None 2021-02-24 15:33:55 UTC

Description Maayan Hadasi 2020-11-15 11:10:43 UTC
Description of problem:
There is no information in UI regarding vddk-init image not found in ‘v2v-vmware’ configmap

In this case the VM import seems to be stuck on 10% and an error can be found in cdi-deployment pod log:
"level":"error","ts":1605106366.84607,"logger":"controller","msg":"Reconciler error","controller":"import-controller","name":"v2v-rhel8-foreman-os-harddisk1","namespace":"default","error":"Found v2v-vmware ConfigMap in namespace openshift-cnv, but it does not contain a 'vddk-init-image' entry."


Version-Release number of selected component (if applicable):
OCP 4.6.3
CNV 2.5.0


How reproducible:
100%


Expected results:
An import error message to let the user know that the migration is blocked due the missing of vddk-init image

Comment 1 Yaacov Zamir 2020-11-17 05:50:54 UTC
note:
targeted 4.7 for now, this RFE may be a large task and we may need to move to track in JIRA for some design work.

Comment 2 Filip Krepinsky 2020-11-19 12:24:42 UTC
Does this concern only a single RHV to CNV import by the Import VM Wizard in the UI? Since we are not using CDI for import in case of vmware.

And in case only RHV VMs are imported, why should vddk-init image be required?

Comment 3 Maayan Hadasi 2020-11-19 13:21:05 UTC
We add the vddk-init-image in "v2v-vmware" ConfigMap as a prerequisite for VMware -> CNV  imports using VMImport operator
There is another bug for blocking such migration when the vddk image is missing and to let the CLI user know with an appropriate error message:
https://bugzilla.redhat.com/show_bug.cgi?id=1898070

In case of creating vmimport CR without having vddk image in configMap, if you switch to OCP UI - it seems as the VM import was started and it remains on 10% (see attached image)
So, it is important that the import error message will be reflected in UI as well

Comment 4 Maayan Hadasi 2020-11-19 13:22:26 UTC
Created attachment 1730931 [details]
ui_screenshot

Comment 5 Filip Krepinsky 2020-11-19 14:54:09 UTC
I see, in that case it might make more sense to fix this just in the backend like https://bugzilla.redhat.com/show_bug.cgi?id=1898070 mentions.

We are just propagating the status of VMImport CR and it would go against the flow a bit if we try to ensure all prerequisites for the import and to check if CDI deployment is running ok.

Comment 6 Yaacov Zamir 2020-11-19 16:50:44 UTC
Set the CLI bug to block this one, see https://bugzilla.redhat.com/show_bug.cgi?id=1897891#c5
Once we have a backend fix it will propagating up to the UI.

Comment 7 Filip Krepinsky 2020-11-19 17:01:42 UTC
+^ yup we should check that the status is propagated correctly afterwards

Comment 8 Yaacov Zamir 2020-12-16 12:21:05 UTC
*** Bug 1887482 has been marked as a duplicate of this bug. ***

Comment 9 Yaacov Zamir 2020-12-16 12:43:10 UTC
It looks fixed on master, moving to ON QA

Comment 11 Ilanit Stein 2020-12-27 11:44:31 UTC
Verified on 4.7.0-fc.0.
In case vddk-init-image is not added to v2v-cmware configMap, there is a warning, and it's not possible to proceed with the VM import without it.

Comment 13 errata-xmlrpc 2021-02-24 15:33:27 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633


Note You need to log in before you can comment on or make changes to this bug.