Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1897905

Summary:	[Assisted-4.6 ]Cluster with disabled host fails to start installation
Product:	OpenShift Container Platform	Reporter:	nshidlin <nshidlin>
Component:	assisted-installer	Assignee:	Michael Filanov <mfilanov>
assisted-installer sub component:	Installer	QA Contact:	Udi Kalifon <ukalifon>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	urgent
Priority:	urgent	CC:	aos-bugs, mfilanov
Version:	4.6
Target Milestone:	---
Target Release:	4.6.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	OCP-Metal-v1.0.11.1	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-08-25 13:49:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description nshidlin 2020-11-15 13:47:35 UTC

Description of problem:
A cluster with 3 masters and 2 "disabled" workers fails to begin installation

Unable to open file /data/fffb12d1-f927-49f5-90f0-4953fa47c578/worker-686715ae-cb78-4ab7-946e-a6a68508378b.ign for upload: open /data/fffb12d1-f927-49f5-90f0-4953fa47c578/worker-686715ae-cb78-4ab7-946e-a6a68508378b.ign: no such file or directory.

Version-Release number of selected component (if applicable):
stable-candidate 11/15/20
deployed on PSI

How reproducible:
Found using e2e test automation, but reproduces manually as well
Every time

Steps to Reproduce:
1. Boot 3 masters and 2 workers into discovery ISO
2. Disable the 2 worker nodes
3. Start installation

Actual results:
Starting cluster installation fails

Expected results:
Cluster installation to succeed 

Additional info:

Comment 1 Michael Filanov 2020-11-15 14:04:07 UTC

From the events we can see that cluster failed to generate and upload ignition files before starting the installation. 

{code}
15/11/2020, 15:42:02	
error
 Host master-0-2: updated status from "preparing-for-installation" to "error" (Host failed to install because its preparation took longer than expected)
{code}

Need to see the logs from the cluster in order to understand the Issue. i would expect the async part to fail without getting into timeout.

Comment 2 Michael Filanov 2020-11-15 14:58:34 UTC

Ignition generation don't skip disabled hosts when try to upload ignition files https://github.com/openshift/assisted-service/blob/master/internal/ignition/ignition.go#L490
Was added with https://github.com/openshift/assisted-service/pull/466

Comment 3 Michael Filanov 2020-11-15 15:14:17 UTC

https://github.com/openshift/assisted-service/pull/676

Comment 4 nshidlin 2020-11-16 06:23:11 UTC

Verified on PSI

Release tag
stable-candidate
Assisted Installer UI version
quay.io/ocpmetal/ocp-metal-ui:bcfb0ea569c1dba73cc4e5eb450239182b645a41
Assisted Installer UI library version
1.4.2
assistedIgnitionGenerator
Assisted Installer
quay.io/ocpmetal/assisted-installer:1edee71e6ae5baa250b52fc050b60d570a089c76
Assisted Installer Controller
quay.io/ocpmetal/assisted-installer-controller:1edee71e6ae5baa250b52fc050b60d570a089c76
Assisted Installer Service
quay.io/ocpmetal/assisted-service:ef59391796e61186e545f55662a0e8b593c60b60
Discovery Agent
quay.io/ocpmetal/assisted-installer-agent:e3ee9677c5a1a810945bf393d1f197c1c15c041c
Image Builder
quay.io/ocpmetal/assisted-iso-create:ef59391796e61186e545f55662a0e8b593c60b60

Comment 7 errata-xmlrpc 2021-08-25 13:49:22 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.6.43 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:3197