Bug 1898093 - libreoffice: SRPM built on Fedora 33 cannot be rebuilt on Fedora > 33
Summary: libreoffice: SRPM built on Fedora 33 cannot be rebuilt on Fedora > 33
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libreoffice
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Caolan McNamara
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.10
TreeView+ depends on / blocked
 
Reported: 2020-11-16 11:06 UTC by Miro Hrončok
Modified: 2020-11-23 20:31 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-11-23 20:31:06 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Miro Hrončok 2020-11-16 11:06:37 UTC 
libreoffice has a conditionally defined patch:

%if 0%{?fedora} > 33 || 0%{?rhel} > 8
Patch5: 0001-Upgrade-liborcus-to-0.16.0.patch
%endif


As a result, when the SRPM is created on Fedora 33, the patch is not in it.

When the SRPM is built on Fedora 34, it fails, because the fiel is missing:


error: Bad file: /builddir/build/SOURCES/0001-Upgrade-liborcus-to-0.16.0.patch: No such file or directory


As a consequence, we cannot easily rebuild libreoffice from dist git in Copr: https://pagure.io/copr/copr/issue/1315

A general sentiment seem to be that packages should avoid doing this, because it breaks stuff. I'll take a look to see if this can be designed in a more robust way.
Comment 1 Miro Hrončok 2020-11-16 11:47:35 UTC 
My take to solve this problem: https://src.fedoraproject.org/rpms/libreoffice/pull-request/8
Note You need to log in before you can comment on or make changes to this bug.