Spec URL: https://build.opensuse.org/package/view_file/home:KingMint/BeeBEEP/beebeep.spec?expand=1 SRPM URL: https://build.opensuse.org/package/binary/download/home:KingMint/BeeBEEP/Fedora_33/x86_64/beebeep-5.8.2-7.1.src.rpm Description: BeeBEEP is a secure network chat. You can talk and send files with all your friends inside a local area network such of an office, home or internet cafe without a server. Fedora Account System Username: Evert Please review this package. Thanks in advance.
spec file with actual changelog: %global debug_package %{nil} Name: beebeep Summary: Secure Network Chat Version: 5.8.2 Release: 1 Group: Applications/Communications URL: http://sourceforge.net/projects/beebeep/ Source0: https://sourceforge.net/projects/beebeep/files/Sources/%{name}-code-%{version}.zip License: Qt Public License BuildRequires: qt5-qtbase-devel BuildRequires: qt5-qtmultimedia-devel BuildRequires: qt5-qtx11extras-devel %description BeeBEEP is a secure network chat. You can talk and send files with all your friends inside a local area network such of an office, home or internet cafe without a server. %prep %setup -q -n %{name}-code-r1352 %build qmake-qt5 -recursive make %{?_smp_mflags} %install mkdir -p %{buildroot}%{_bindir} mv test/%{name} %{buildroot}%{_bindir}/%{name} mkdir -p %{buildroot}%{_libdir} cp -a test/* %{buildroot}%{_libdir} %files %doc *.txt %{_bindir}/%{name} %{_libdir}/lib* %changelog * Mon Nov 16 2020 Evert <evert.p.augstinus 5.8.2 - Build for Fedora 33 * Fri Sep 06 2019 Wei-Lun Chao <bluebat.org> - 5.6.8 - Rebuild for Fedora
The spec should be posted as a link, not in a comment. As for the links in the original post: a) The spec links points to an HTML web-view of the file. Please use "raw file" links. b) The SRPM link asks me to log in before I can fetch the file. > Review Request: beebeep - My first package that i want to contribute to the community The ticket title should describe what the package does. >Group: Applications/Communications Not used in Fedora. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections >License: Qt Public License The LICENSE.txt file in the repo says that it's actually GPLv3. https://sourceforge.net/p/beebeep/code/HEAD/tree/LICENSE.txt >%global debug_package %{nil} This is generally a red flag. We *want* debuginfo to be generated. If your package fails to build without this line, it means that the binaries (i.e. executables and libraries) do not contain debug symbols; either they are compiled without debuginfo degeneration, or they are stripped at some point. https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/ >qmake-qt5 -recursive Use the "%qmake_qt5" macro here instead. It should set up Fedora's CXXFLAGS properly, possibly solving the issue with missing debuginfo.
Two additional points: 1. The changelog is incorrect (mentions an outdated version) 2. This Bugzilla ticket's summary should have this format: "Review Request: <main package name here> - <short summary here>"
Setting to NotReady until some of the comments are addressed.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.