Bug 189830 - Review Request: xmms-scrobbler - Audioscrobbler plugin for XMMS
Review Request: xmms-scrobbler - Audioscrobbler plugin for XMMS
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: David Cantrell
Fedora Package Reviews List
:
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2006-04-24 18:29 EDT by Andreas Thienemann
Modified: 2013-01-09 20:23 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-04-27 12:34:59 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Andreas Thienemann 2006-04-24 18:29:28 EDT
Spec URL: http://home.bawue.de/~ixs/xmms-scrobbler/xmms-scrobbler.spec
SRPM URL: http://home.bawue.de/~ixs/xmms-scrobbler/xmms-scrobbler-0.3.6-1.src.rpm
Description:
This is an audioscrobbler xmms plugin.
Audioscrobbler will send the name of every song you play on your computer
to Last.fm. This effortlessly populates your profile to play radio you like
and make personalised recommendations!
Comment 1 Jesse Keating 2006-04-27 00:01:50 EDT
Bad:
- Buildroot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

Question:
- Will your defatter make the docs files be installed with 0755 permissions?  If
so, this isn't right.

Haven't tested mock building or rpmlint, will check tomorrow.
Comment 2 Andreas Thienemann 2006-04-27 08:18:29 EDT
Updated files at http://home.bawue.de/~ixs/xmms-scrobbler/
The permission issue is fixed as well as it came from the template-spec I copied.
Comment 3 Jesse Keating 2006-04-27 11:55:11 EDT
Changes look good, rpmlint is silent, builds on i386/x86_64, I think we're good
to go.

ACCEPT.
Comment 4 Andreas Thienemann 2006-04-27 12:34:59 EDT
Thx for the review.

Package has been updated to current 0.3.8 (upstream changed urls. gnarghl.) and
build. closing as nextrelease.
Comment 5 Christian Iseli 2007-01-01 17:38:57 EST
Fix typo.

Note You need to log in before you can comment on or make changes to this bug.