Bug 189874 - Review Request: perl-Test-SubCalls - Track the number of times subs are called
Review Request: perl-Test-SubCalls - Track the number of times subs are called
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2006-04-25 09:45 EDT by Jose Pedro Oliveira
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2006-04-25 12:09:48 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Jose Pedro Oliveira 2006-04-25 09:45:59 EDT
Spec URL:


There are a number of different situations (like testing cacheing
code) where you want to want to do a number of tests, and then verify
that some underlying subroutine deep within the code was called a
specific number of times.

1 - Targets: FE5 and devel (due to Test::* version requirements)
2 - Last requirement for http://search.cpan.org/dist/PPI/
Comment 1 Jason Tibbitts 2006-04-25 11:22:18 EDT
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* license field matches the actual license.
* license is open source-compatible and included in the package.
* source files match upstream:
   23ae21fea8a30477aba508b4a6f785b5  Test-SubCalls-0.05.tar.gz
   23ae21fea8a30477aba508b4a6f785b5  Test-SubCalls-0.05.tar.gz-srpm
* BuildRequires are proper.
* package builds in mock (development, i386).
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directory it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

Comment 2 Jose Pedro Oliveira 2006-04-25 12:09:48 EDT
Thanks for the review.

Imported and built for FC-5 and devel.

Will try to finish the PPI specfile shortly
(beta: http://gsd.di.uminho.pt/jpo/software/fedora/perl-PPI-1.112-0.src.rpm)

Note You need to log in before you can comment on or make changes to this bug.