Bug 1898858 - [RFE] Add to the Variables the option to select one or more
Summary: [RFE] Add to the Variables the option to select one or more
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-dwh
Classification: oVirt
Component: Grafana
Version: 4.4.3
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.4.5
: 4.4.5.4
Assignee: Aviv Litman
QA Contact: Pavel Novotny
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-11-18 09:19 UTC by Aviv Litman
Modified: 2021-03-18 15:15 UTC (History)
4 users (show)

Fixed In Version: ovirt-engine-dwh-4.4.5.4
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-03-18 15:15:49 UTC
oVirt Team: Metrics
Embargoed:
mperina: ovirt-4.4?
pm-rhel: planning_ack?
mperina: devel_ack+
gdeolive: testing_ack+


Attachments (Terms of Use)
'Multi-value' and 'Include All options' set to false (96.38 KB, image/png)
2020-11-18 09:19 UTC, Aviv Litman
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 112266 0 master MERGED Add Multi-valu to Trend Dashboard Variables 2021-02-15 20:49:43 UTC
oVirt gerrit 112987 0 master MERGED Add Multi-valu to Inventory Dashboard Variables 2021-02-15 20:49:44 UTC
oVirt gerrit 112988 0 master MERGED Add Multi-valu to Service Level Dashboard Variables 2021-02-15 20:49:44 UTC
oVirt gerrit 112995 0 master MERGED Add Multi-valu to Executive Dashboard Variables 2021-02-15 20:49:43 UTC

Description Aviv Litman 2020-11-18 09:19:03 UTC
Created attachment 1730497 [details]
'Multi-value' and 'Include All options' set to false

Created attachment 1730497 [details]
'Multi-value' and 'Include All options' set to false

Description of problem:
We want to add to all variables the option to select one, more than one, or all.
In order to do this we will need to change the settings of the variable and in addition adjust the queries in the places where the modified variables appear


Verification steps:
1.Go to the dashboard with variables
2.Make sure in each variable that one or more options can be selected and that there is also an "all" selection.
3.Make sure the data displayed in the panels matches the selections of the variables

Actual results:
In some variables in Selection Options the 'Multi-value' and 'Include All options' set to false.
The queries are suitable for variables without a multiple choice option. 

Expected results:
In All variables in Selection Options the 'Multi-value' and 'Include All options' set to true.
The queries are suitable for variables with multiple choice option.

Notes for QA:
Need to check that you can choose 'all' or less in all variables except 3 dashboards that we will not add this fix to their variables:
1. Cluster Dashboard
2. Data Center Dashboard 
3. System Dashboard (do not have variables anyway)

Comment 1 RHEL Program Management 2020-11-18 09:19:12 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 2 Pavel Novotny 2021-03-16 21:34:49 UTC
Verified in
ovirt-engine-4.4.5.9-0.1.el8ev.noarch
ovirt-engine-dwh-4.4.5.5-1.el8ev.noarch

Variables in all dashboards (except Cluster/DC/Host/VM/System Executive dashboards) are multi-value,
allowing to select 'All' or individual value(s).
The panels with data tables and graphs are updated depending on the value(s) selection.

Comment 3 Sandro Bonazzola 2021-03-18 15:15:49 UTC
This bugzilla is included in oVirt 4.4.5 release, published on March 18th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.