Spec URL: http://people.redhat.com/green/FE/FC5/liblo.spec SRPM URL: http://people.redhat.com/green/FE/FC5/liblo-0.23-3.src.rpm Description: liblo is an implementation of the Open Sound Control protocol for POSIX systems developed by Steve Harris. Adapted from an old ccrma spec file.
God: + Local build works fine. + Source in the rpm are the same as upstream. + Build on mock works fine. + rpmlint of source rpm ok. + rpmlint of binaries rpms ok. ü can start example_server and example_client without a crash Bad: - The BuildRoot must be cleaned at the beginning of %install -
Thanks for looking at this. (In reply to comment #1) > Bad: > - The BuildRoot must be cleaned at the beginning of %install > - It is, isn't it? The spec file reads... %install %{__rm} -rf %{buildroot} %{__make} DESTDIR=%{buildroot} install
Whats the point of macros such as %{__rm} and %{__make}? I've seen them in some packages and have never quite understood why they exist. Fedora wiki doesn't say anything about them that I've seen. (And the spec template doesn't use them...) My personal preference is to avoid macros.
(In reply to comment #3) > Whats the point of macros such as %{__rm} and %{__make}? I have no idea, and always wondered this myself. I'm guessing at one time there was a policy to never invoke commands directly in spec files so everything can be overridden by redefining macros.
If that's the case I'd definately lose them. :)
(In reply to comment #5) > If that's the case I'd definately lose them. :) Done... Spec URL: http://people.redhat.com/green/FE/FC5/liblo.spec SRPM URL: http://people.redhat.com/green/FE/FC5/liblo-0.23-4.src.rpm
I'm happy to inform you, that your package is approved.
Thanks!