Bug 1898980 - rdiff-backup fails to build with Python 3.10: Py_TYPE= needs to be replaced with Py_SET_TYPE
Summary: rdiff-backup fails to build with Python 3.10: Py_TYPE= needs to be replaced w...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: rdiff-backup
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.10
TreeView+ depends on / blocked
 
Reported: 2020-11-18 12:38 UTC by Miro Hrončok
Modified: 2020-11-19 12:04 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-11-18 19:45:54 UTC
Type: Bug


Attachments (Terms of Use)

Description Miro Hrončok 2020-11-18 12:38:56 UTC
rdiff-backup fails to build with Python 3.10.0a2.

src/_librsyncmodule.c: In function ‘PyInit__librsync’:
src/_librsyncmodule.c:543:36: error: lvalue required as left operand of assignment
  543 |   Py_TYPE(&_librsync_SigMakerType) = &PyType_Type;
      |                                    ^
src/_librsyncmodule.c:544:38: error: lvalue required as left operand of assignment
  544 |   Py_TYPE(&_librsync_DeltaMakerType) = &PyType_Type;
      |                                      ^
error: command '/usr/bin/gcc' failed with exit code 1


https://docs.python.org/3.10/whatsnew/3.10.html

Since Py_TYPE() is changed to the inline static function, Py_TYPE(obj) = new_type must be replaced with Py_SET_TYPE(obj, new_type): see Py_SET_TYPE() (available since Python 3.9). For backward compatibility, this macro can be used:

#if PY_VERSION_HEX < 0x030900A4
#  define Py_SET_TYPE(obj, type) ((Py_TYPE(obj) = (type)), (void)0)
#endif

https://bugs.python.org/issue39573


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/01773504-rdiff-backup/

For all our attempts to build rdiff-backup with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/rdiff-backup/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Miro Hrončok 2020-11-18 17:57:13 UTC
The change was reverted in Python 3.10, because it caused too much trouble (the amount of affected Fedora packages was too big). Keeping this open for now, unit  anew alpha version is out to test it out.

This comment is mass posted in all relevant bugzillas. If you already worked upstream to fix the problem, please let them know about the revert.

https://github.com/python/cpython/commit/0e2ac21dd

Comment 2 Miro Hrončok 2020-11-18 19:45:54 UTC
I've patched Python 3.10 in our testing copr to include the revert. This package built fine. Sorry for the noise.


Note You need to log in before you can comment on or make changes to this bug.