Bug 1899154 - python-piexif fails to build with Python 3.10: struct.error: ubyte format requires 0 <= number <= 255 [NEEDINFO]
Summary: python-piexif fails to build with Python 3.10: struct.error: ubyte format req...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-piexif
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Igor Raits
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.10
TreeView+ depends on / blocked
 
Reported: 2020-11-18 15:53 UTC by Tomáš Hrnčiar
Modified: 2021-01-20 14:02 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-01-20 10:47:54 UTC
Type: Bug
thrnciar: needinfo? (igor.raits)


Attachments (Terms of Use)

Description Tomáš Hrnčiar 2020-11-18 15:53:06 UTC
python-piexif fails to build with Python 3.10.0a2.

ERROR: test_load (s_test.ExifTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./tests/s_test.py", line 110, in test_load
    self._compare_piexifDict_PILDict(exif, e, p=False)
  File "./tests/s_test.py", line 614, in _compare_piexifDict_PILDict
    self._compare_value(zeroth_ifd[key], pilDict[key])
  File "./tests/s_test.py", line 585, in _compare_value
    self.assertEqual(pack_byte(*v1), v2)
  File "./tests/s_test.py", line 87, in pack_byte
    return struct.pack("B" * len(args), *args)
struct.error: ubyte format requires 0 <= number <= 255

======================================================================
ERROR: test_load_m (s_test.ExifTests)
'load' on memory.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./tests/s_test.py", line 118, in test_load_m
    self._compare_piexifDict_PILDict(exif, e)
  File "./tests/s_test.py", line 614, in _compare_piexifDict_PILDict
    self._compare_value(zeroth_ifd[key], pilDict[key])
  File "./tests/s_test.py", line 585, in _compare_value
    self.assertEqual(pack_byte(*v1), v2)
  File "./tests/s_test.py", line 87, in pack_byte
    return struct.pack("B" * len(args), *args)
struct.error: ubyte format requires 0 <= number <= 255

======================================================================
ERROR: test_load_unicode_filename (s_test.ExifTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./tests/s_test.py", line 186, in test_load_unicode_filename
    self._compare_piexifDict_PILDict(exif, e, p=False)
  File "./tests/s_test.py", line 614, in _compare_piexifDict_PILDict
    self._compare_value(zeroth_ifd[key], pilDict[key])
  File "./tests/s_test.py", line 585, in _compare_value
    self.assertEqual(pack_byte(*v1), v2)
  File "./tests/s_test.py", line 87, in pack_byte
    return struct.pack("B" * len(args), *args)
struct.error: ubyte format requires 0 <= number <= 255

----------------------------------------------------------------------
Ran 55 tests in 0.122s

FAILED (errors=3)
Test failed: <unittest.runner.TextTestResult run=55 errors=3 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=55 errors=3 failures=0>
error: Bad exit status from /var/tmp/rpm-tmp.jpnKrx (%check)
    Bad exit status from /var/tmp/rpm-tmp.jpnKrx (%check)



For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/01773318-python-piexif/

For all our attempts to build python-piexif with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/python-piexif/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Tomáš Hrnčiar 2021-01-20 09:18:55 UTC
Hello, is there any update on this? It blocks us from testing other packages (ginga, python-nikola) with Python 3.10. Thank you.

Comment 3 Tomáš Hrnčiar 2021-01-20 14:02:30 UTC
Thank you!


Note You need to log in before you can comment on or make changes to this bug.