Bug 1899461 - python-pyside2 fails to build with Python 3.10: popd: directory stack empty
Summary: python-pyside2 fails to build with Python 3.10: popd: directory stack empty
Keywords:
Status: CLOSED WORKSFORME
Alias: None
Product: Fedora
Classification: Fedora
Component: python-pyside2
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Richard Shaw
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.10
TreeView+ depends on / blocked
 
Reported: 2020-11-19 10:12 UTC by Miro Hrončok
Modified: 2020-11-19 22:44 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-11-19 22:05:33 UTC
Type: Bug


Attachments (Terms of Use)

Description Miro Hrončok 2020-11-19 10:12:32 UTC
python-pyside2 fails to build with Python 3.10.0a2.

...
-- Installing: /builddir/build/BUILDROOT/python-pyside2-5.15.1-1.fc34.x86_64/usr/include/PySide2/Qt3DExtras/pyside2_qt3dextras_python.h
-- Installing: /builddir/build/BUILDROOT/python-pyside2-5.15.1-1.fc34.x86_64/usr/share/PySide2/typesystems/typesystem_3dextras.xml
-- Installing: /builddir/build/BUILDROOT/python-pyside2-5.15.1-1.fc34.x86_64/usr/bin/pyside_tool.py
-- Installing: /builddir/build/BUILDROOT/python-pyside2-5.15.1-1.fc34.x86_64/usr/bin/pyside2-lupdate
-- Installing: /builddir/build/BUILDROOT/python-pyside2-5.15.1-1.fc34.x86_64/usr/share/man/man1/pyside2-lupdate.1
+ popd
/var/tmp/rpm-tmp.ROewav: line 41: popd: directory stack empty
error: Bad exit status from /var/tmp/rpm-tmp.ROewav (%install)

No idea :/


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/01774096-python-pyside2/

For all our attempts to build python-pyside2 with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/python-pyside2/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Richard Shaw 2020-11-19 12:51:53 UTC
This was part of a workaround for the stupid^H^H^H^H^H cmake change that only got applied to some releases of Fedora/EL instead of all releases. Working on it...

Comment 2 Richard Shaw 2020-11-19 21:24:35 UTC
Ok, the popd problem is fixed but then I ran into this:

***** Exception while trying to prepare bdist_wheel override class: cannot import name 'pep425tags' from 'wheel' (/usr/lib/python3.10/site-packages/wheel/__init__.py). Skipping wheel overriding.
Unsupported python version detected. Only these python versions are supported: [(2, 7), (3, 5), (3, 6), (3, 7), (3, 8), (3, 9)]
error: Bad exit status from /var/tmp/rpm-tmp.BixP5u (%install)
    Bad exit status from /var/tmp/rpm-tmp.BixP5u (%install)

Apparently there's one more place 3.10 needs to be added.

Comment 3 Richard Shaw 2020-11-19 21:27:06 UTC
I updated the patch to include 3.10. Perhaps I did it incorrectly?

Index: pyside-setup-opensource-src-5.14.2/build_scripts/config.py
===================================================================
--- pyside-setup-opensource-src-5.14.2.orig/build_scripts/config.py
+++ pyside-setup-opensource-src-5.14.2/build_scripts/config.py
@@ -92,6 +92,8 @@ class Config(object):
             'Programming Language :: Python :: 3.6',
             'Programming Language :: Python :: 3.7',
             'Programming Language :: Python :: 3.8',
+            'Programming Language :: Python :: 3.9',
+            'Programming Language :: Python :: 3.10',
         ]

         self.setup_script_dir = None
@@ -134,7 +135,7 @@ class Config(object):
         setup_kwargs['zip_safe'] = False
         setup_kwargs['cmdclass'] = cmd_class_dict
         setup_kwargs['version'] = package_version
-        setup_kwargs['python_requires'] = ">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*, <3.9"
+        setup_kwargs['python_requires'] = ">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*, <=3.10"


         if quiet:

Comment 4 Richard Shaw 2020-11-19 22:05:33 UTC
Forgot I had disabled the patch because a newer version supported Python 3.9. The patch has now been updated for 3.10 and I was able to complete a build from the referenced mock configuration.

I have pushed the changes into master.

Comment 5 Miro Hrončok 2020-11-19 22:44:41 UTC
Thank You!


Note You need to log in before you can comment on or make changes to this bug.