Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1899514

Summary:	networking-ovn code is broken and duplicated
Product:	Red Hat OpenStack	Reporter:	Jakub Libosvar <jlibosva>
Component:	python-networking-ovn	Assignee:	RHOS Maint <rhos-maint>
Status:	CLOSED DUPLICATE	QA Contact:	Eran Kuris <ekuris>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	13.0 (Queens)	CC:	apevec, egarciar, lhh, majopela, oblaut, scohen
Target Milestone:	z13	Keywords:	AutomationBlocker, Triaged, ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-03-17 10:49:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jakub Libosvar 2020-11-19 13:17:30 UTC

Description of problem:
The codebase is broken, there is a lot of duplicated code which may lead unpredicted behavior:

[0;31m  /home/cloud-user/networking-ovn$ /home/cloud-user/networking-ovn/.tox/pep8/bin/flake8 [0m
[0;31m./networking_ovn/common/maintenance.py:460:5: F811 redefinition of unused '_check_subnet_global_dhcp_opts' from line 347[0m
[0;31m    def _check_subnet_global_dhcp_opts(self):[0m
[0;31m    ^[0m
[0;31m./networking_ovn/common/maintenance.py:491:5: F811 redefinition of unused 'check_global_dhcp_opts' from line 378[0m
[0;31m    @periodics.periodic(spacing=600,[0m
[0;31m    ^[0m
[0;31m./networking_ovn/common/maintenance.py:525:5: F811 redefinition of unused 'check_metadata_ports' from line 412[0m
[0;31m    @periodics.periodic(spacing=1800, run_immediately=True)[0m
[0;31m    ^[0m
[0;31m./networking_ovn/common/maintenance.py:544:5: F811 redefinition of unused 'check_for_port_security_unknown_address' from line 431[0m
[0;31m    @periodics.periodic(spacing=600, run_immediately=True)[0m
[0;31m    ^[0m
[0;31m./networking_ovn/common/utils.py:442:1: F811 redefinition of unused 'is_neutron_dhcp_agent_port' from line 421[0m
[0;31mdef is_neutron_dhcp_agent_port(port):[0m
[0;31m^[0m
[0;31mERROR: InvocationError: '/home/cloud-user/networking-ovn/.tox/pep8/bin/flake8'[0m
[0;31m___________________________________ summary ____________________________________[0m


Version-Release number of selected component (if applicable):




It seems it's been broken by an import from upstream and not solving the conflicts correctly.

Comment 1 Jakub Libosvar 2020-11-19 13:22:08 UTC

I will write the RPM version once Jenkins starts responding.

Comment 2 Jakub Libosvar 2020-11-19 13:27:33 UTC

We don't know exactly because our history goes only to the beginning of September. It's been already broken there.

Comment 5 Elvira 2021-03-17 10:49:40 UTC

There's a fix for this already. Closing as duplicate.

*** This bug has been marked as a duplicate of bug 1935136 ***