Description of problem:
Translation came back to us with questions about an internationalized sentence fragment "Recommended builder images are represented by" in Developer console. I looked for it and found it in packages/dev-console/src/components/import/builder/BuilderImageSelector.tsx. We should be using the <Trans> component there instead of breaking the sentence up into fragments.
Version-Release number of selected component (if applicable):
Sentence is broken into fragments that are hard to translate.
It should be a complete sentence wrapped by the Trans component.
I checked openshift/console#7284 and openshift/console#7285 on 4.7.0-0.nightly-2020-11-22-123106
Here are my steps to verify them:
To verify bug 1900008, I visited <console_route>/deploy-image/ns/openshift-console?pseudolocalization=true&lng=en but the sentence `To deploy an image from a private repository, you must create an image pull secret with your image registry credentials.` is not translated
To verify bug 1900010, I visited <console_route>/import/ns/openshift-console?pseudolocalization=true&lng=en, search https://github.com/openshift/ruby-hello-world Git Repo, but sentence `Recommended builder images are represented by (star) icon.` is not translated
How can I check the pseudolocalization internationalization of these sentences?
# oc adm release info registry.svc.ci.openshift.org/ocp/release:4.7.0-0.nightly-2020-11-22-123106 --pullspecs | grep console
# oc image info quay.io/openshift-release-dev/ocp-v4.0-art-dev@sha256:39c1286b4552b31f179ce098dc7c91bf01ce372fe263c6504275caf2689a75f7 | grep commit
# git log 6427365dac7d0cdadeb487c6b7fdec34a562d157 | grep '#7284'
Merge pull request #7284 from rebeccaalpert/fix-translation
# git log 6427365dac7d0cdadeb487c6b7fdec34a562d157 | grep '#7285'
Merge pull request #7285 from rebeccaalpert/i18n-fix-fragment
4.7.0-0.nightly-2020-11-22-123106 already contains the two fix PRs
Created attachment 1732610 [details]
Import from Git - pseudolocalized
Created attachment 1732611 [details]
Deploy Image - pseudolocalized
Hey @email@example.com - I followed your instructions and was able to see the text pseudolocalized (see attachments). I'm wondering if this isn't a bug with the query parameter.
Created attachment 1733247 [details]
Import from Git - translated
Thank you Rebecca,
I tried today on 4.7.0-0.nightly-2020-11-24-151855 and all working as expected.
`Recommended builder images are represented by (star) icon.` sentence is wrapped in `<Trans>` component and they are translated, see my screenshot
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.