Bug 1900145 - Review Request: perl-ProjectBuilder - perl modules from the project-builder.org project used by MondoRescue
Summary: Review Request: perl-ProjectBuilder - perl modules from the project-builder.o...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: NotReady
Depends On:
Blocks: FE-DEADREVIEW 1900146
TreeView+ depends on / blocked
 
Reported: 2020-11-21 00:26 UTC by Bruno Cornec
Modified: 2022-04-29 00:45 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-04-29 00:45:23 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Bruno Cornec 2020-11-21 00:26:19 UTC
Spec URL: ftp://ftp.mondorescue.org/test/fedora/33/x86_64/perl-ProjectBuilder.spec
SRPM URL: ftp://ftp.mondorescue.org/test/fedora/33/x86_64/perl-ProjectBuilder-0.16.2-0.20201118030309.s2659M.fc33.src.rpm
Description: ProjectBuilder is a perl module providing set of functions
to help develop packages for projects and deal
with different Operating systems (Linux distributions, Solaris, ...).
It implements a Continuous Packaging approach.
Fedora Account System Username: bcornec

Comment 1 Bruno Cornec 2020-11-21 01:05:27 UTC
I'm the upstream maintainer of this SW.

Comment 2 Jitka Plesnikova 2020-12-04 11:03:53 UTC
Do you want to add the package to EPEL 7? If not, there is a lot of code which can be removed.

Btw. the source link does not work.

Comment 3 Bruno Cornec 2020-12-04 23:24:45 UTC
Yes this SW works for a large set of LInux distributions (CentOS, RHEL, Fedora included)
I'm not sure why the links are not working for you however, as I just checked again and they do for me.

Comment 4 Petr Pisar 2021-01-14 12:19:20 UTC
The Url value works, but the server redirects to <http://trac.project-builder.org/>. Please add the trailing slash to the Url value in the spec file.
Source value does not work. The spec file links to <ftp://ftp.project-builder.org/test/src/ProjectBuilder-0.16.2.0.20201118030309.tar.gz>, but there is no such file on the server. The only similar file there is ProjectBuilder-0.16.2.0.20210106113635.tar.gz. Please update your spec file the new upstream release.

I also recommend you reading Fedora packaging guide lines <https://docs.fedoraproject.org/en-US/packaging-guidelines/> and update your spec file accordingly:

Group and BuildRoot tags should not used <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections>
Release value must use %{?dist} macro <https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/>.
You need to specify all build-time dependencies (perl-interpreter for perl program, make for make, findutils for find, coreutils for rm, and perl(FOO) for any FOO Perl module used from your tests).
You should use %{make_build} and %{make_install} macros instead of "make %{?_smp_mflags}" and "make DESTDIR=${RPM_BUILD_ROOT} install". Please see <https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/> and <https://fedoraproject.org/wiki/Perl/Tips#ExtUtils::MakeMaker> how to package Perl code in Fedora.
You should remove %clean section.
You should remove %defattr(-,root,root,-) from %files section.
You have to use %license macro for the COPYING file <https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/>.

Comment 5 Neal Gompa 2021-01-14 12:31:30 UTC
Also, if it's possible, it'd be *greatly* preferred if the links are HTTPS instead of HTTP or FTP.

Comment 6 Ben Beasley 2021-03-14 16:30:51 UTC
In addition to the good suggestions already given here, please consider applying the fedora-review tool to your own package, as a lot of the things that need to be changed are ones it will flag automatically.

Comment 7 Package Review 2022-03-30 00:45:19 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 8 Package Review 2022-04-29 00:45:23 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.