Spec URL: ftp://ftp.mondorescue.org/test/fedora/33/x86_64/perl-ProjectBuilder.spec SRPM URL: ftp://ftp.mondorescue.org/test/fedora/33/x86_64/perl-ProjectBuilder-0.16.2-0.20201118030309.s2659M.fc33.src.rpm Description: ProjectBuilder is a perl module providing set of functions to help develop packages for projects and deal with different Operating systems (Linux distributions, Solaris, ...). It implements a Continuous Packaging approach. Fedora Account System Username: bcornec
I'm the upstream maintainer of this SW.
Do you want to add the package to EPEL 7? If not, there is a lot of code which can be removed. Btw. the source link does not work.
Yes this SW works for a large set of LInux distributions (CentOS, RHEL, Fedora included) I'm not sure why the links are not working for you however, as I just checked again and they do for me.
The Url value works, but the server redirects to <http://trac.project-builder.org/>. Please add the trailing slash to the Url value in the spec file. Source value does not work. The spec file links to <ftp://ftp.project-builder.org/test/src/ProjectBuilder-0.16.2.0.20201118030309.tar.gz>, but there is no such file on the server. The only similar file there is ProjectBuilder-0.16.2.0.20210106113635.tar.gz. Please update your spec file the new upstream release. I also recommend you reading Fedora packaging guide lines <https://docs.fedoraproject.org/en-US/packaging-guidelines/> and update your spec file accordingly: Group and BuildRoot tags should not used <https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections> Release value must use %{?dist} macro <https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/>. You need to specify all build-time dependencies (perl-interpreter for perl program, make for make, findutils for find, coreutils for rm, and perl(FOO) for any FOO Perl module used from your tests). You should use %{make_build} and %{make_install} macros instead of "make %{?_smp_mflags}" and "make DESTDIR=${RPM_BUILD_ROOT} install". Please see <https://docs.fedoraproject.org/en-US/packaging-guidelines/Perl/> and <https://fedoraproject.org/wiki/Perl/Tips#ExtUtils::MakeMaker> how to package Perl code in Fedora. You should remove %clean section. You should remove %defattr(-,root,root,-) from %files section. You have to use %license macro for the COPYING file <https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/>.
Also, if it's possible, it'd be *greatly* preferred if the links are HTTPS instead of HTTP or FTP.
In addition to the good suggestions already given here, please consider applying the fedora-review tool to your own package, as a lot of the things that need to be changed are ones it will flag automatically.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.