Bug 1900540 - Engine try to stop NBD server during online backup
Summary: Engine try to stop NBD server during online backup
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.4.4.1
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.4.4
: 4.4.4.3
Assignee: Eyal Shenitzky
QA Contact: Ilan Zuckerman
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-11-23 10:27 UTC by Nir Soffer
Modified: 2021-01-12 16:24 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-01-12 16:24:02 UTC
oVirt Team: Storage
Embargoed:

Attachments (Terms of Use)
Logs from 4 backups showing the issue (85.56 KB, application/gzip)
2020-11-23 10:27 UTC, Nir Soffer 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 112416 0 master MERGED core: skip stopping NBD server for downloading a backup image 2021-01-05 08:07:28 UTC

Description Nir Soffer 2020-11-23 10:27:41 UTC 
Created attachment 1732432 [details]
Logs from 4 backups showing the issue

Description of problem:

During online backup, we use qemu nbd server, not vdsm nbd server. However 
when image transfer is finalized, engine tries to stop vdsm nbd server:

2020-11-22 18:37:24,172+02 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.StopNbdServerVDSCommand] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-83) [6008f89e-8d91-4e24-853f-b6fabbf7a81a] START, StopNbdServerVDSCommand(HostName = host3, NbdServerVDSParameters:{hostId='f1593c12-5d93-444b-99f4-cd31ffd45506', serverId='25a9f1cd-ef6a-48a4-af7a-54775fb9e415', storageDomainId='null', imageId='null', volumeId='null', readonly='false', discard='false', backingChain='true'}), log id: 7549e12

2020-11-22 18:37:24,198+02 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.StopNbdServerVDSCommand] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-83) [6008f89e-8d91-4e24-853f-b6fabbf7a81a] FINISH, StopNbdServerVDSCommand, return: , log id: 7549e12

The call succeeds in vdsm since this API is designed to do nothing if NBD
server is not running, but calling it is wrong, and may fail or delay the
transfer finalization if the call to vdsm fails.

Version-Release number of selected component (if applicable):
4.4.4.2_master

How reproducible:
Always

Steps to Reproduce:
1. Start backup
2. Stop backup

Actual results:
Engine try to stop NBD server

Expected results:
Engine should skip this step when during online backup.

Additional info:
During offline backup this step is needed.
Comment 1 Ilan Zuckerman 2020-12-29 07:51:00 UTC 
Verified on rhv-4.4.4-6

1. start backup with backup.vm script
2. stop the backup with the same script

Expected:
The specified above log lines should not appear in the engine log

Actual:
As expected.
Comment 2 Sandro Bonazzola 2021-01-12 16:24:02 UTC 
This bugzilla is included in oVirt 4.4.4 release, published on December 21st 2020.

Since the problem described in this bug report should be resolved in oVirt 4.4.4 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Note You need to log in before you can comment on or make changes to this bug.