Spec URL: https://mattia.fedorapeople.org/python-graphql-server.spec SRPM URL: https://mattia.fedorapeople.org/python-graphql-server-3.0.0-1.b2.fc34.src.rpm Description: GraphQL-Server is a base library that serves as a helper for building GraphQL servers or integrations into existing web frameworks using GraphQL-Core. Fedora Account System Username: mattia Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=56179689 Note that rpmlint will throw some errors about "line too long" in metapackages created by python_extras_subpkg macro... https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_python_extras
I noticed that the extra subpackages use "+" as a separator. Shouldn't they use "-" instead or are these flavors of the -server package? > Name: python-%{srcname} > Version: 3.0.0 > Release: 1.b2%{?dist} The "b2" part should be in the Version field, I think. It's not a part of the Fedora package Release tag, but rather of the version string of the upstream package. > License: MIT > URL: https://pypi.python.org/pypi/%{srcname} > Source0: %{pypi_source graphql-server 3.0.0b2} You can probably reuse %{version} in the Source0 field. > %prep > %autosetup -n %{srcname}-%{version}b2 Also here, once Version is fixed. > %changelog > * Tue Nov 24 2020 Mattia Verga <mattia.verga> - 3.0.0-1b2 > - Initial packaging Same here. Upstream provides tests in the PyPi tarball. Can these be added to the SPEC file under %check or do they require external binaries, like a server daemon? The rest looks okay. Package approved. Full review below: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 50 files have unknown license. Detailed output of licensecheck in /data/rpmbuild/SPECS/python-graphql-server/python-graphql- server/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: python3-graphql-server-3.0.0-1.b2.fc34.noarch.rpm python-graphql-server-3.0.0-1.b2.fc34.src.rpm python3-graphql-server.noarch: W: spelling-error %description -l en_US integrations -> integration, integration's, integration s python-graphql-server.src: W: spelling-error %description -l en_US integrations -> integration, integration's, integration s 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- (none): E: no installed packages by name python3-graphql-server 0 packages and 0 specfiles checked; 0 errors, 0 warnings. Source checksums ---------------- https://files.pythonhosted.org/packages/source/g/graphql-server/graphql-server-3.0.0b2.tar.gz : CHECKSUM(SHA256) this package : 91b790086fb29ae2883194a2a5cd7c2f73521923c425837e33d932033dd0c2f6 CHECKSUM(SHA256) upstream package : 91b790086fb29ae2883194a2a5cd7c2f73521923c425837e33d932033dd0c2f6 Requires -------- python3-graphql-server (rpmlib, GLIBC filtered): (python3.9dist(graphql-core) < 4 with python3.9dist(graphql-core) >= 3.1) (python3.9dist(typing-extensions) < 4 with python3.9dist(typing-extensions) >= 3.7.4) python(abi) Provides -------- python3-graphql-server: python-graphql-server python3-graphql-server python3.9-graphql-server python3.9dist(graphql-server) python3dist(graphql-server)
(In reply to Andy Mender from comment #1) > I noticed that the extra subpackages use "+" as a separator. Shouldn't they > use "-" instead or are these flavors of the -server package? > That's the way Fedora has chosen to name the extras provided by the package. Everything is made automatically by the macro: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_python_extras > > Name: python-%{srcname} > > Version: 3.0.0 > > Release: 1.b2%{?dist} > > The "b2" part should be in the Version field, I think. It's not a part of > the Fedora package Release tag, but rather of the version string of the > upstream package. > No, 3.0.0b2 does not sort properly, since 3.0.0 will be lower: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_unsortable_versions 'b2' must go in <extraver>. > Upstream provides tests in the PyPi tarball. Can these be added to the SPEC > file under %check or do they require external binaries, like a server daemon? > Can't run tests, since sanic package isn't available > The rest looks okay. Package approved. Thank you!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-graphql-server
> No, 3.0.0b2 does not sort properly, since 3.0.0 will be lower: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_unsortable_versions > 'b2' must go in <extraver>. Right, makes sense. Thanks a lot for the clarification :)!