Bug 1901092 - Review Request: rust-enumset_derive - Internal helper crate for enumset
Summary: Review Request: rust-enumset_derive - Internal helper crate for enumset
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1901095
TreeView+ depends on / blocked
 
Reported: 2020-11-24 13:40 UTC by Olivier Lemasle
Modified: 2021-05-24 01:01 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-05-10 18:22:18 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Olivier Lemasle 2020-11-24 13:40:37 UTC
Spec URL: https://olem.fedorapeople.org/reviews/rust-enumset_derive.spec
SRPM URL: https://olem.fedorapeople.org/reviews/rust-enumset_derive-0.5.0-1.fc33.src.rpm

Description:
Internal helper crate for enumset. Not public API.

Fedora Account System Username: olem

Comment 1 Olivier Lemasle 2020-11-24 13:40:39 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=56192042

Comment 2 Robert-André Mauchin 🐧 2021-01-20 19:13:12 UTC
 - Please ask upstream to include the license files and readme in the crate

 - Build fails:

   Compiling enumset_derive v0.5.0 (/builddir/build/BUILD/enumset_derive-0.5.0)
     Running `/usr/bin/rustc --crate-name enumset_derive --edition=2018 src/lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type proc-macro --emit=dep-info,link -C prefer-dynamic -C opt-level=3 -C embed-bitcode=no -C metadata=f1d05392172fa523 -C extra-filename=-f1d05392172fa523 --out-dir /builddir/build/BUILD/enumset_derive-0.5.0/target/release/deps -L dependency=/builddir/build/BUILD/enumset_derive-0.5.0/target/release/deps --extern darling=/builddir/build/BUILD/enumset_derive-0.5.0/target/release/deps/libdarling-4853d2ce570ec900.rlib --extern proc_macro2=/builddir/build/BUILD/enumset_derive-0.5.0/target/release/deps/libproc_macro2-3feabf62339f3e7b.rlib --extern quote=/builddir/build/BUILD/enumset_derive-0.5.0/target/release/deps/libquote-9b517b766eaaf53c.rlib --extern syn=/builddir/build/BUILD/enumset_derive-0.5.0/target/release/deps/libsyn-538054f1d15a956a.rlib --extern proc_macro -Copt-level=3 -Cdebuginfo=2 -Clink-arg=-Wl,-z,relro,-z,now -Ccodegen-units=1 --cap-lints=warn`
error[E0432]: unresolved import `syn::export`
  --> src/lib.rs:10:10
   |
10 | use syn::export::Span;
   |          ^^^^^^ could not find `export` in `syn`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0432`.
error: could not compile `enumset_derive`

See https://github.com/dtolnay/syn/issues/956

Comment 3 Robert-André Mauchin 🐧 2021-01-20 19:16:11 UTC
Also https://github.com/Lymia/enumset/issues/17

Comment 4 Robert-André Mauchin 🐧 2021-01-20 19:25:13 UTC
Also upstream seems dead, whatever project you need this for probably needs to find a replacement.

Comment 5 Olivier Lemasle 2021-01-27 15:20:04 UTC
Hi Robert-André,

"The reports of upstream's death are greatly exaggerated" ;-)

Upstream has been updated to fix the issue, due to an incompatibility in latest version of its dependency syn.

Please find the updated spec and SRPM:

Spec URL: https://olem.fedorapeople.org/reviews/rust-enumset_derive.spec
SRPM URL: https://olem.fedorapeople.org/reviews/rust-enumset_derive-0.5.1-1.fc33.src.rpm

Koji scratch build (successful): https://koji.fedoraproject.org/koji/taskinfo?taskID=60656210

I've also asked the maintainer to add readme and license in crates: https://github.com/Lymia/enumset/issues/19

Comment 6 Robert-André Mauchin 🐧 2021-01-27 23:26:45 UTC
 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 7 Olivier Lemasle 2021-01-28 00:03:55 UTC
Thank you Robert-André.

https://pagure.io/releng/fedora-scm-requests/issue/31916

Comment 8 Robert-André Mauchin 🐧 2021-01-28 15:57:47 UTC
Also if you packkage golang-github-containerd-stargz-snapshotter too, needinfo me to review it.

Comment 9 Mohan Boddu 2021-01-29 16:36:58 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-enumset_derive

Comment 10 Fedora Update System 2021-05-15 20:02:04 UTC
FEDORA-2021-2f88c6f685 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-2f88c6f685

Comment 11 Fedora Update System 2021-05-16 02:47:59 UTC
FEDORA-2021-2f88c6f685 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-2f88c6f685 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-2f88c6f685

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2021-05-24 01:01:04 UTC
FEDORA-2021-2f88c6f685 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.