Bug 1901129 - Review Request: rust-bytemuck_derive - Derive proc-macros for `bytemuck`
Summary: Review Request: rust-bytemuck_derive - Derive proc-macros for `bytemuck`
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Olivier Lemasle
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1892913
TreeView+ depends on / blocked
 
Reported: 2020-11-24 14:47 UTC by Fabio Valentini
Modified: 2021-01-12 18:15 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-01-12 18:15:01 UTC
Type: ---
Embargoed:
o.lemasle: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2020-11-24 14:47:04 UTC
Spec URL: https://decathorpe.fedorapeople.org/packages/rust-bytemuck_derive.spec
SRPM URL: https://decathorpe.fedorapeople.org/packages/rust-bytemuck_derive-1.0.0-1.fc33.src.rpm

Description:
Derive proc-macros for `bytemuck`

Fedora Account System Username: decathorpe

koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=56195215

Comment 1 Fabio Valentini 2020-11-30 09:29:53 UTC
New URLs for version 1.0.1, which includes the License files:

Spec URL: https://decathorpe.fedorapeople.org/packages/rust-bytemuck_derive.spec
SRPM URL: https://decathorpe.fedorapeople.org/packages/rust-bytemuck_derive-1.0.1-1.fc33.src.rpm

Comment 2 Olivier Lemasle 2021-01-11 21:59:39 UTC
Package accepted.

- License ok
- Spec generated by rust2rpm; only variation is related to additional %license and %doc.
- Latest upstream is packaged
- Guidelines and naming conventions ok
- Builds in mock


Rpmlint
-------
Checking: rust-bytemuck_derive-devel-1.0.1-1.fc34.noarch.rpm
          rust-bytemuck_derive+default-devel-1.0.1-1.fc34.noarch.rpm
          rust-bytemuck_derive-1.0.1-1.fc34.src.rpm
rust-bytemuck_derive-devel.noarch: W: spelling-error Summary(en_US) proc -> crop, prov, pro
rust-bytemuck_derive-devel.noarch: W: spelling-error Summary(en_US) bytemuck -> byte muck, byte-muck, buckteeth
rust-bytemuck_derive-devel.noarch: W: spelling-error %description -l en_US proc -> crop, prov, pro
rust-bytemuck_derive-devel.noarch: W: spelling-error %description -l en_US bytemuck -> byte muck, byte-muck, buckteeth
rust-bytemuck_derive-devel.noarch: W: invalid-url URL: https://crates.io/crates/bytemuck_derive HTTP Error 404: Not Found
rust-bytemuck_derive-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/bytemuck_derive-1.0.1/.cargo-checksum.json
rust-bytemuck_derive+default-devel.noarch: W: spelling-error Summary(en_US) proc -> crop, prov, pro
rust-bytemuck_derive+default-devel.noarch: W: spelling-error Summary(en_US) bytemuck -> byte muck, byte-muck, buckteeth
rust-bytemuck_derive+default-devel.noarch: W: spelling-error %description -l en_US proc -> crop, prov, pro
rust-bytemuck_derive+default-devel.noarch: W: spelling-error %description -l en_US bytemuck -> byte muck, byte-muck, buckteeth
rust-bytemuck_derive+default-devel.noarch: W: invalid-url URL: https://crates.io/crates/bytemuck_derive HTTP Error 404: Not Found
rust-bytemuck_derive+default-devel.noarch: W: no-documentation
rust-bytemuck_derive.src: W: spelling-error Summary(en_US) proc -> crop, prov, pro
rust-bytemuck_derive.src: W: spelling-error Summary(en_US) bytemuck -> byte muck, byte-muck, buckteeth
rust-bytemuck_derive.src: W: spelling-error %description -l en_US proc -> crop, prov, pro
rust-bytemuck_derive.src: W: spelling-error %description -l en_US bytemuck -> byte muck, byte-muck, buckteeth
rust-bytemuck_derive.src: W: invalid-url URL: https://crates.io/crates/bytemuck_derive HTTP Error 404: Not Found
3 packages and 0 specfiles checked; 0 errors, 17 warnings.

Comment 3 Fabio Valentini 2021-01-12 10:18:38 UTC
Thanks for the review!
https://pagure.io/releng/fedora-scm-requests/issue/31713

Comment 4 Gwyn Ciesla 2021-01-12 14:17:13 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-bytemuck_derive

Comment 5 Fabio Valentini 2021-01-12 18:15:01 UTC
Built for rawhide:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1668459


Note You need to log in before you can comment on or make changes to this bug.