Bug 1901609 - storageResources settings for Prometheus and Alertmanager have no effect
Summary: storageResources settings for Prometheus and Alertmanager have no effect
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Service Telemetry Framework
Classification: Red Hat
Component: service-telemetry-operator-container
Version: 1.1
Hardware: All
OS: Unspecified
high
high
Target Milestone: GA
: 1.2 (STF)
Assignee: Leif Madsen
QA Contact: Leonid Natapov
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-11-25 15:59 UTC by Chris Sibbitt
Modified: 2021-02-23 19:18 UTC (History)
7 users (show)

Fixed In Version: service-telemetry-operator-container-1.2.0-9
Doc Type: Bug Fix
Doc Text:
Previously, invalid storage templates resulted in the inability to set custom storageClass parameter for OpenShift Container Platform (OCP). With this release, the ability to set custom storage parameters means that you can use STF with non-default storageClasses in OCP, such as OCS.
Clone Of:
Environment:
Last Closed: 2021-02-23 19:18:41 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github infrawatch service-telemetry-operator pull 150 0 None closed Fix storageclass selection 2021-02-12 20:24:26 UTC
Red Hat Product Errata RHEA-2021:0649 0 None None None 2021-02-23 19:18:45 UTC

Description Chris Sibbitt 2020-11-25 15:59:02 UTC
Description of problem:

Setting alerting.storage.persistent.storageResources has no effect.

Version-Release number of selected component (if applicable):
STF-1.1

How reproducible:
Always

Steps to Reproduce:
1. Set alerting.alertmanager.storage.persistent.storageResources in your STF manifest


Actual results:
Nothing you set appears as part of the resulting alertmanager manifest


Expected results:
I expected these to become part of the storage definition in the alertmanager manifest as shown here: https://github.com/infrawatch/service-telemetry-operator/blob/f84753a2a70ff1cc8d5ad888654f253f4f7c6c92/roles/servicetelemetry/templates/manifest_alertmanager.j2#L17

Additional info:
* This parameter, along with the selector and class are in the wrong part of the manifest. Resources belongs under volumeClaimTemplate.spec
* However, the storageSize is the only resource we can manage this way, and it is already accounted for with this pvc_storage_request parameter
* Therefore this parameter is useless and can be removed (it never worked, so won't cause any regression)

This problem is already fixed upstream, this BZ exists to track the resulting CRD change during the release process.

Comment 4 Leif Madsen 2021-01-06 15:02:09 UTC
Getting flags aligned. Target is STF 1.2 as the fix is merged upstream and will be imported into stable-1.2 when that branch is created. Will move to MODIFIED once we have a service-telemetry-operator-container image built downstream.

Comment 5 Leif Madsen 2021-02-01 20:58:14 UTC
Moved back to ON_DEV due to issue in https://bugzilla.redhat.com/show_bug.cgi?id=1918781. Will require a re-spin.

Comment 11 errata-xmlrpc 2021-02-23 19:18:41 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Release of components for Service Telemetry Framework 1.2 - Operator Container), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:0649


Note You need to log in before you can comment on or make changes to this bug.