Spec URL: https://salimma.fedorapeople.org/specs/lua/lua-readline.spec SRPM URL: https://salimma.fedorapeople.org/specs/lua/lua-readline-2.7-1.fc33.src.rpm Description: This Lua module offers a simple calling interface to the GNU Readline/History Library. Fedora Account System Username: salimma
I'm completely unfamiliar with LUA packaging so bear with me... 1. Where does the license come from? There's nothing in the package and licensecheck couldn't derive anything from the files in the archive. 2. Is the C- prepended on the library because it's C based? There doesn't seem to be any official LUA packaging guidelines for Fedora.
(In reply to Richard Shaw from comment #1) > I'm completely unfamiliar with LUA packaging so bear with me... > > 1. Where does the license come from? There's nothing in the package and > licensecheck couldn't derive anything from the files in the archive. > Yeah, nothing in the tarball mentions the license. It's listed in Luarocks (Lua's equivalent to pypi) (which is linked to from the documentation): http://luarocks.org/modules/peterbillam/readline (if you click on any of the version e.g. 2.7-0 and look at the rockspec file, it lists the license too) > 2. Is the C- prepended on the library because it's C based? There doesn't > seem to be any official LUA packaging guidelines for Fedora. I'm following the author's intention here. The Lua module (readline.lua) requires the C module as C-readline: specs/lua/readline-2.7 on master [?] ❯ grep "require 'C-readline'" readline.lua local initialise = require 'C-readline' I'm working on packaging guidelines for Lua (as well as some automated packaging tool) but they're not ready yet, my bad. Hopefully soon enough we'll be able to run `rock2spec readline` and it will download the rockspec and generate a reasonable spec.
Ok, that's enough for me, I don't think there's enough going on here to justify running fedora-review on. I verified the build flags are being honored and you're installing to a private library location outside of straight /usr/lib{,64}. *** APPROVED ***
Thanks! ❯ fedpkg request-repo lua-readline 1901740 https://pagure.io/releng/fedora-scm-requests/issue/31116
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/lua-readline
FEDORA-2020-55ecb451a4 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-55ecb451a4
FEDORA-2020-55ecb451a4 has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-55ecb451a4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-55ecb451a4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-e38a7ce355 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-e38a7ce355 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e38a7ce355 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2020-60e20c51e4 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-60e20c51e4
FEDORA-EPEL-2020-60e20c51e4 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-60e20c51e4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-55ecb451a4 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2020-e38a7ce355 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2020-60e20c51e4 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report.