Bug 1901978 - 20201118-115.fc33 - sienna (RX6800) firmware files not available, previously added in 20201022-114.fc33
Summary: 20201118-115.fc33 - sienna (RX6800) firmware files not available, previously ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: linux-firmware
Version: 33
Hardware: All
OS: Linux
unspecified
urgent
Target Milestone: ---
Assignee: David Woodhouse
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-11-26 14:16 UTC by mershl
Modified: 2021-01-02 01:50 UTC (History)
6 users (show)

Fixed In Version: linux-firmware-20201218-116.fc33 linux-firmware-20201218-116.fc32
Clone Of:
Environment:
Last Closed: 2020-12-21 01:32:57 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description mershl 2020-11-26 14:16:12 UTC
Description of problem:
System is not able to kms due to missing firmware for RX6800 (sienna_cichlid) with 20201118-115.fc33.

https://bodhi.fedoraproject.org/updates/FEDORA-2020-ff2b09cd0a states the inclusion of the sienna firmware in 1022.

Seen behavior:
rpm -ql linux-firmware | grep sienna -> returns empty on 20201118-115.fc33

Boot shows:
kernel: amdgpu 0000:0a:00.0: amdgpu: failed to init sos firmware
kernel: [drm:psp_sw_init [amdgpu]] *ERROR* Failed to load psp firmware!
kernel: [drm:amdgpu_device_init.cold [amdgpu]] *ERROR* sw_init of IP block <psp> failed -2
kernel: amdgpu 0000:0a:00.0: amdgpu: amdgpu_device_ip_init failed
kernel: amdgpu 0000:0a:00.0: amdgpu: Fatal error during GPU init

Comment 1 mershl 2020-11-26 14:43:43 UTC
The build log of 1022 is mentioning the sienna binary. But the files are indeed not included in the rpm.

Comment 2 mershl 2020-11-26 16:47:22 UTC
There seems to be a bug in the spec of linux-firmware. A local rpmbuild shows that the extra package "updated-amdgpu-fw.tar.gz" is extracted but the files are later not included.

Comment 3 mershl 2020-11-26 17:19:02 UTC
The added firmware files are not part of the list of included files generated by the following lines in the spec:

pushd %{buildroot}/%{_firmwarepath}
find . \! -type d > $FILEDIR/linux-firmware.files
find . -type d | sed -e '/^.$/d' > $FILEDIR/linux-firmware.dirs
popd

Comment 4 mershl 2020-11-26 17:45:25 UTC
Adding "tar xzf %{SOURCE1} -C %{buildroot}/%{_firmwarepath}" as an install step to the spec fixes the issue.

Comment 5 Peter Robinson 2020-11-26 18:08:51 UTC
(In reply to mershl from comment #4)
> Adding "tar xzf %{SOURCE1} -C %{buildroot}/%{_firmwarepath}" as an install
> step to the spec fixes the issue.

No, it works around this issue. There was nothing of note changed from the prior revision, literally updating to the new upstream release of linux-firmware and removing the verbose option on the tar command.

Comment 6 mershl 2020-11-26 18:14:36 UTC
Hi Peter,

It seems the prior release was also missing the sienna blobs. Just downgraded and "rpm -ql linux-firmware | grep sienna" -> returns empty for 1022. Hmmm, sorry for the confusion.

Including the files in the buildroot, then building the rpm and rebooting still shows a firmware load error for the RX6800 I'm testing. No luck so far.

Comment 7 Peter Robinson 2020-11-26 18:19:29 UTC
(In reply to mershl from comment #6)
> Hi Peter,
> 
> It seems the prior release was also missing the sienna blobs. Just
> downgraded and "rpm -ql linux-firmware | grep sienna" -> returns empty for
> 1022. Hmmm, sorry for the confusion.
> 
> Including the files in the buildroot, then building the rpm and rebooting
> still shows a firmware load error for the RX6800 I'm testing. No luck so far.

Right, so the problem I suspect is the WHENCE file wasn't patched and that is the reference for where the files are copied to so this isn't a regression. I'm not sure I want to churn this for all the other thousands of Fedora users for the few that have these cards when the next upstream-linux release will properly have it all.

Comment 8 mershl 2020-11-26 18:41:25 UTC
Unfortunatly the last release was 1 day (11-18) before the upstream support for sienna (11-19 - https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?id=54c797a694d3830ef93f349ec25e1d96d4b88102).

As the releases usually happen every ~6 weeks this would be quite rogue for users of the RX6xxx series.

Comment 9 mershl 2020-11-26 21:56:44 UTC
Built linux-firmware with upstream locally using your spec, Peter. The RX6800 is not able to boot on 5.9.10 even with the sienna firmware included. Updating to 5.10.rc5 did the trick. Working perfectly now.

Comment 10 Fedora Update System 2020-12-19 10:41:34 UTC
FEDORA-2020-53df9f500d has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-53df9f500d

Comment 11 Fedora Update System 2020-12-19 10:41:35 UTC
FEDORA-2020-39f7307164 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-39f7307164

Comment 12 Fedora Update System 2020-12-20 01:03:04 UTC
FEDORA-2020-39f7307164 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-39f7307164`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-39f7307164

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2020-12-20 02:02:13 UTC
FEDORA-2020-53df9f500d has been pushed to the Fedora 32 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-53df9f500d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-53df9f500d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2020-12-21 01:32:57 UTC
FEDORA-2020-39f7307164 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2021-01-02 01:50:09 UTC
FEDORA-2020-53df9f500d has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.