Bug 1902537 - The default fsfreeze-hook path from man page and qemu-ga --help command are different
Summary: The default fsfreeze-hook path from man page and qemu-ga --help command are d...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux Advanced Virtualization
Classification: Red Hat
Component: qemu-kvm
Version: 8.4
Hardware: Unspecified
OS: Linux
low
low
Target Milestone: rc
: 8.0
Assignee: Marc-Andre Lureau
QA Contact: dehanmeng
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-11-30 02:16 UTC by dehanmeng
Modified: 2021-05-25 06:45 UTC (History)
7 users (show)

Fixed In Version: qemu-kvm-5.2.0-6.module+el8.4.0+9871+53903be9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-05-25 06:45:10 UTC
Type: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description dehanmeng 2020-11-30 02:16:29 UTC
Description of problem:
Check fsfreeze-hook default path via qemu-ga man page and "qemu-ga -h" commands, they are different, one is /etc/qemu/fsfreeze-hook, the other is etc/qemu-ga/fsfreeze-hook.
This bug was hit similar issue again like https://bugzilla.redhat.com/show_bug.cgi?id=1751509, but this time hit it on rhel8.4.0 guest.

Version-Release number of selected component (if applicable):
kernel-4.18.0-249.el8.x86_64
seabios-bin-1.14.0-1.module+el8.4.0+8855+a9e237a9.noarch
qemu-kvm-5.2.0-0.module+el8.4.0+8855+a9e237a9.x86_64
qemu-guest-agent-5.2.0-0.module+el8.4.0+8855+a9e237a9.x86_64

How reproducible:
always

Steps to Reproduce:
1.Start rhel8.4.0 guest and intall qemu-guest-agent-5.2.0-0.module+el8.4.0+8855+a9e237a9.x86_64

2.Try to stop qemu-ga service.
systemctl stop qemu-guest-agent.service

3.Start gagent with -F option; Start gagent with -F option --> Try to start qemu-ga service.
qemu-ga -m virtio-serial -p /dev/virtio-ports/org.qemu.guest_agent.0 -F -d

4.Get the default path of fsfreeze-hook in qemu-ga help.
qemu-ga --help | grep 'fsfreeze-hook' | tail -1

5.Get the default path of fsfreeze-hook in man page.;Export qemu-ga man page to guest file.
export LC_ALL="en_US.UTF-8"; man qemu-ga |col -b > /tmp/man_file

6.Get fsfreeze-hook script default path in the file.
cat /tmp/man_file |grep /fsfreeze-hook


Actual results:
it's in help cmd is /etc/qemu-kvm/fsfreeze-hook
it's in man page is /etc/qemu/fsfreeze-hook

Expected results:
# qemu-ga -h
/etc/qemu-kvm/fsfreeze-hook
# man page
/etc/qemu-kvm/fsfreeze-hook
Additional info:

Comment 1 Marc-Andre Lureau 2020-12-01 18:28:36 UTC
Argh, this is a regression from

commit f8aa24ea9a82da38370470c6bc0eaa393999edfe
Author: Paolo Bonzini <pbonzini>
Date:   Wed Aug 5 15:49:10 2020 +0200

    meson: sphinx-build

CONFDIR is not passed via environment variable anymore.

Comment 2 Marc-Andre Lureau 2020-12-01 18:38:25 UTC
Sent upstream: "[PATCH] docs: set CONFDIR when running sphinx"

Comment 3 Marc-Andre Lureau 2021-02-08 09:38:43 UTC
Sent [RHEL-AV-8.4.0 qemu-kvm PATCH] docs: set CONFDIR when running sphinx

Comment 6 dehanmeng 2021-02-10 00:53:41 UTC
Reproduce with qemu-kvm-5.2.0-0.module+el8.4.0+8855+a9e237a9.x86_64
step as comment0

Actual results:
it's in help cmd is /etc/qemu-kvm/fsfreeze-hook
it's in man page is /etc/qemu/fsfreeze-hook

Expected results:
# qemu-ga -h
/etc/qemu-kvm/fsfreeze-hook
# man page
/etc/qemu-kvm/fsfreeze-hook

Verify with qemu-kvm-5.2.0-6.module+el8.4.0+9871+53903be9
step as comment0

Actual results:
it's in help cmd is /etc/qemu-kvm/fsfreeze-hook
it's in man page is /etc/qemu-kvm/fsfreeze-hook

Expected results:
# qemu-ga -h
/etc/qemu-kvm/fsfreeze-hook
# man page
/etc/qemu-kvm/fsfreeze-hook

Comment 9 errata-xmlrpc 2021-05-25 06:45:10 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virt:av bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:2098


Note You need to log in before you can comment on or make changes to this bug.