Bug 1902736 - [RFE] Use custom stdout callback with the validation framework
Summary: [RFE] Use custom stdout callback with the validation framework
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: python-validations-libs
Version: 16.2 (Train)
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: Alpha
: 16.2 (Train on RHEL 8.4)
Assignee: mathieu bultel
QA Contact: nlevinki
URL:
Whiteboard:
: 1941591 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-11-30 14:22 UTC by mathieu bultel
Modified: 2023-09-15 00:52 UTC (History)
11 users (show)

Fixed In Version: python-validations-libs-1.0.5-2.20210325011040.6a20089.el8ost, python-tripleoclient-12.4.1-2.20210328010120.1a88932.el8ost, validations-common-1.1.2-2.20210210010444.dea7b49.el8ost
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-09-15 07:10:41 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
OpenStack gerrit 761626 0 None MERGED Allow to provide different stdout callback to the libs 2021-02-15 15:24:52 UTC
OpenStack gerrit 761721 0 None MERGED Add dedicated stdout callback for VF library 2021-02-15 15:24:52 UTC
OpenStack gerrit 773603 0 None MERGED Expose callback_whitelist option to Run action 2021-03-25 06:20:04 UTC
OpenStack gerrit 782899 0 None MERGED Use MultiKeyActionValue action for extra-[env-]vars arguments 2021-03-30 04:31:14 UTC
OpenStack gerrit 782900 0 None MERGED Use MultiKeyActionValue action for extra-[env-]vars arguments 2021-03-30 04:31:16 UTC
OpenStack gerrit 782902 0 None MERGED Use MultiKeyActionValue action for extra-[env-]vars arguments 2021-03-30 04:31:18 UTC
OpenStack gerrit 783297 0 None MERGED Use MultiKeyActionValue action for extra-[env-]vars arguments 2021-04-06 18:02:26 UTC
Red Hat Issue Tracker VALFRWK-373 0 None None None 2021-08-13 05:47:50 UTC
Red Hat Product Errata RHEA-2021:3483 0 None None None 2021-09-15 07:10:58 UTC

Description mathieu bultel 2020-11-30 14:22:20 UTC 
Currently, the Validation Framework used a specific callback to run the validation with Ansible. This callback is responsible of the logging and the stdout printing on the console.

The goal of the RFE is to be able the use a custom stdout callback, like the Ansible default, or others and still logging as the framework is expected.
Comment 3 mathieu bultel 2021-01-07 14:55:06 UTC 
For QE validations and testing it will be:

1/ provide another callback via the CLI option with:
    --extra-env-vars ANSIBLE_STDOUT_CALLBACK=default

So the output on the console should be print as the default Ansible output.

2/ non regression testing.
Comment 4 Cédric Jeanneret 2021-02-10 10:12:00 UTC 
Upstream merged, moving to POST.
Comment 7 Gaël Chamoulaud 2021-03-25 11:52:23 UTC 
Resetting the FIV.

Quick status:
- https://review.opendev.org/773603 has been merged upstream and already included in python-validations-libs-1.0.5-2.20210325011040.6a20089.el8ost[1]


[1] https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=1549459
Comment 8 Gaël Chamoulaud 2021-03-31 06:41:56 UTC 
*** Bug 1941591 has been marked as a duplicate of this bug. ***
Comment 10 David Rosenfeld 2021-04-14 13:09:14 UTC 
Still seeing the old cli:

openstack tripleo validator run --validation check-ram --extra-env-vars ANSIBLE_STDOUT_CALLBACK=default
usage: openstack tripleo validator run [--plan PLAN] [--ssh-user SSH_USER]
                                       [--limit LIMIT]
                                       [--python-interpreter PYTHON_INTERPRETER]
                                       [--extra-vars EXTRA_VARS | --extra-vars-file EXTRA_VARS_FILE | --extra-env-vars EXTRA_ENV_VARS | --static-inventory STATIC_INVENTORY]
                                       (--validation <validation_id>[,<validation_id>,...] | --group <group>[,<group>,...])
openstack tripleo validator run: error: argument --extra-env-vars: invalid loads value: 'ANSIBLE_STDOUT_CALLBACK=default'

It looks like the required tripleoclient is not in the RHOS-16.2-RHEL-8-20210409.n.0 build:

yum list installed | grep tripleoclient
python3-tripleoclient.noarch                  12.4.1-2.20210316010910.7536d5b.el8ost.1    @rhelosp-16.2
Comment 19 David Rosenfeld 2021-05-25 19:50:11 UTC 
All polarion test cases passed for custom callback feature.
Comment 22 errata-xmlrpc 2021-09-15 07:10:41 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform (RHOSP) 16.2 enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:3483
Comment 23 Red Hat Bugzilla 2023-09-15 00:52:09 UTC 
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days
Note You need to log in before you can comment on or make changes to this bug.