Spec URL: ftp://ftp.infradead.org/pub/mtd-utils/mtd-utils.spec SRPM URL: ftp://ftp.infradead.org/pub/mtd-utils/mtd-utils-1.0.0-1.src.rpm Description: Utilities for dealing with MTD (flash) devices.
I'll review this tonight. At first glance, it seems fine.
Completed MUST items: - rpmlint output: [jwboyer@vader i386]$ rpmlint -v mtd-utils-1.0.0-1.i386.rpm I: mtd-utils checking [jwboyer@vader i386]$ - named according to the Package Naming guidlines - spec file name matches %{name}.spec - meets Packaging Guidelines - licensed under the GPL - License: field matches - MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. - source SHA1 sum matches upstream - compiles and builds on x86 Two small nits: - The package should probably throw a Requires: zlib and BuildRequires: zlib-devel in the spec file. - The upstream source lacks a copy of the license text. It would be nice if the upstream source could include this at some point, but is not required. I'm assuming David will fixup the zlib issues. After that is done, I consider this approved.
Added BuildRequires: zlib-devel Added COPYING (and also upstream from your git tree) Not added Requires: zlib since that's automatic. Imported and built. Thanks.