Red Hat Bugzilla – Bug 190310
Review Request: perl-File-Find-Rule-PPI - Add support for PPI queries to File::Find::Rule
Last modified: 2007-11-30 17:11:31 EST
File::Find::Rule::PPI allows you to integrate PPI content queries into
your File::Find::Rule searches.
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
follows the Perl template.
* license field matches the actual license.
* license is open source-compatible; text is included in the package.
* source files match upstream:
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
All tests successful.
Files=3, Tests=7, 1 wallclock secs ( 0.24 cusr + 0.09 csys = 0.33 CPU)
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
Thanks for the review.
Imported and built for FC-5 and devel.