Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1903208

Summary:	Retry for connection reset by peer doesn't work when syncing docker repository
Product:	Red Hat Satellite	Reporter:	James Jeffers <jjeffers>
Component:	Pulp	Assignee:	satellite6-bugs <satellite6-bugs>
Status:	CLOSED ERRATA	QA Contact:	Lai <ltran>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.8.0	CC:	egolov, hyu, mmccune, ttereshc
Target Milestone:	6.8.2	Keywords:	Regression, Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-nectar-1.6.3	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1903046	Environment:
Last Closed:	2020-12-15 13:15:26 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description James Jeffers 2020-12-01 16:14:50 UTC

+++ This bug was initially created as a clone of Bug #1903046 +++

Description of problem:
This is the regression of bug 1822560. 

The retry doesn't work because the following lines are checking the wrong element in the dictionary.

https://github.com/pulp/nectar/blob/master/nectar/downloaders/threaded.py#L348
https://github.com/pulp/nectar/blob/master/nectar/downloaders/threaded.py#L378

# The alue of e.args is:
(104, 'Connection reset by peer')


# retry only if there's indication of connection reset
if nretry < DEFAULT_GENERIC_TRIES - 1 and e.args[1] == errno.ECONNRESET:  <==== Error code should be in e.args[0]
    continue

Comment 8 Lai 2020-12-11 20:52:52 UTC

Steps to retest

1. Install the new nectar build 1.6.3
2. Set the log_level to DEBUG in the /etc/pulp/server.conf
3. Create a custom docker repo for openshift3/mediawiki-apb on https://registry.redhat.io
3. Include the correct login credentials to access that repo
4. Sync repo
5. Check logs for "Connection reset message."

Expected result:
4. Repo sync successfully
5. In the logs look for "Connection reset. Retrying to connect to {url}" https://github.com/pulp/nectar/pull/<#>/file#diff-<name>

Actual:
4. Repo sync successfully
5. Log doesn't display "connection reset. Retrying to connect to..."

Cannot see "connection reset.  Retrying to connect to..." in log was because the condition cannot be reproduce 100%.  Regardless, this is verify since it's not negatively affecting syncing, but should be noted if the problem does present itself in the future.

Verified that it's in python-nectar-1.6.4-1.el7sat.noarch

Verified on 6.8.2_04

Comment 15 errata-xmlrpc 2020-12-15 13:15:26 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Satellite 6.8.2 Async Bug Fix Update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:5467