Bug 190367 - Review Request: PyKDE: Python bindings for KDE
Summary: Review Request: PyKDE: Python bindings for KDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Michael J Knox
QA Contact: Fedora Package Reviews List
Depends On:
TreeView+ depends on / blocked
Reported: 2006-05-01 17:33 UTC by Rex Dieter
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Clone Of:
Last Closed: 2006-07-24 12:35:35 UTC

Attachments (Terms of Use)

Comment 1 Rex Dieter 2006-05-01 17:34:20 UTC
For devel/fc6 branch only, since it requires sip >= 4.4.3

Comment 2 Rex Dieter 2006-05-12 17:38:08 UTC
Spec URL:

* Fri May 12 2006 Rex Dieter 3.15.2-0.3.20060422
- drop sip-abi crud, rely (only) on
  Requires: PyQt

Comment 3 Michael J Knox 2006-07-21 02:48:24 UTC
Seeing how this has been sitting for a bit, I will do the review. 

Review for release 0.4.20060422:

* Source PyKDE-snapshot20060422.tar.gz is the same as upstream
* This is the latest version
* Builds fine in mock
* rpmlint of PyKDE-devel looks OK
* rpmlint of PyKDE looks OK
* File list of PyKDE-devel looks OK
* File list of PyKDE looks OK

Needs work:
* Package does not follow Fedora's package naming guildlines
  (wiki: PackageNamingGuidelines)

I am not certain, but the package naming guidelines talk about the use of cvs in
the snapshot version. I noticed this is an upstream snapshot, so I am not sure
if this applies. 

* The package should contain the text of the license
  (wiki: Packaging/ReviewGuidelines)

There is a COPYING in the tarball, it should be added to the %docs

This package is also GPL not MIT. 

* Duplicate BuildRequires: python-devel (by sip-devel), sip-devel (by PyQt-devel)

Comment 4 Rex Dieter 2006-07-21 11:26:39 UTC
> * Package does not follow Fedora's package naming guildlines

IMO, it does, since as you noted, this is an upstream snapshot.

> * Duplicate BuildRequires: python-devel (by sip-devel), sip-devel (by 
> PyQt-devel)

this package directly uses the items used in the BuildRequires, and it's not
wise to rely upon implied dependancies of other pkgs.

Comment 5 Rex Dieter 2006-07-21 11:32:27 UTC
Spec URL:

* Fri Jul 21 2006 Rex Dieter <rexdieter[AT]users.sf.net> 3.15.2-0.5.20060422
- License: GPL

Comment 6 Michael J Knox 2006-07-21 21:22:09 UTC
OK, thats what I thought re "cvs". 

As for the BR. I kinda disagree, as we rely on implied depends everwhere else.
However, its not a blocker, so consider it APPROVED. 

Please remember to close this review once imported into CVS. 

Comment 7 Rex Dieter 2006-07-24 12:35:35 UTC
Thanks, importing...

Note You need to log in before you can comment on or make changes to this bug.