Bug 1904047 - Add types of storage and storage domain to enum_translator table (enums.sql)
Summary: Add types of storage and storage domain to enum_translator table (enums.sql)
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-dwh
Classification: oVirt
Component: Grafana
Version: 4.4.4
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.4.5
: 4.4.5
Assignee: Aviv Litman
QA Contact: Pavel Novotny
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-12-03 12:27 UTC by Aviv Litman
Modified: 2021-03-23 17:13 UTC (History)
4 users (show)

Fixed In Version: ovirt-engine-dwh-4.4.5
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-03-23 17:13:41 UTC
oVirt Team: Metrics
Embargoed:
pm-rhel: ovirt-4.4+
gdeolive: testing_ack+


Attachments (Terms of Use)
Example of a missing storage domain type breaking a panel (81.45 KB, image/png)
2020-12-03 12:41 UTC, Aviv Litman
no flags Details
example for: STORAGE_DOMAIN_TYPE: 4 Image (138.20 KB, image/png)
2021-01-26 11:06 UTC, Aviv Litman
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 112487 0 master MERGED Add types of storage and storage domain to enum_translator table 2021-02-11 14:54:11 UTC

Description Aviv Litman 2020-12-03 12:27:21 UTC
Description of problem:


Adding missing types of storage and storage domain (missing from the enum_translator table)
The keys and types currently available in enum_translator table do not cover all cases, 
causing queries that use unfamiliar keys to break or display null. 
Therefore we would like to add the missing keys and types to the table.

I will do this by adding a file named: 
04_04_0010_add_storage_and_storage_domain_enums.sql

To the folder:
ovirt-dwh/packaging/dbscripts/upgrage

keys and Types added:
STORAGE_DOMAIN_TYPE:
4	Image
5	Volume
6	Unknown
7	ManagedBlockStorage
8	Unmanaged

STORAGE_TYPE:
7	GLUSTERFS
8	GLANCE
9	CINDER
10	MANAGED_BLOCK_STORAGE
11	UNMANAGED

Notes for QA:
Need to check that all this new types added to enum_translator. for each type there is 7 records (7 Language codes).
you can see in the screenshot an example for:
STORAGE_DOMAIN_TYPE:
4	Image

Comment 1 Aviv Litman 2020-12-03 12:41:47 UTC
Created attachment 1736084 [details]
Example of a missing storage domain type breaking a panel

Comment 2 Aviv Litman 2021-01-26 11:06:06 UTC
Created attachment 1750860 [details]
example for: STORAGE_DOMAIN_TYPE: 4	Image

Comment 3 Pavel Novotny 2021-03-18 21:42:58 UTC
Verified in
ovirt-engine-4.4.5.9-0.1.el8ev.noarch
ovirt-engine-dwh-4.4.5.5-1.el8ev.noarch

Verified that Storage Domains Inventory Dashboard works with storage types Glusterfs, NFS and iSCSI (I don't have access to more storage types).

For languages, I verified that the dashboard works with all the 10 supported languages (set via browser locale).
Although I am not sure if it is the way Grafana languages should work (I didn't find any language switcher in the UI).
Plus this GH issue https://github.com/grafana/grafana/issues/448 shows that the Grafana i18n is still pending.

Comment 4 Sandro Bonazzola 2021-03-23 17:13:41 UTC
This bugzilla is included in oVirt 4.4.5 release, published on March 18th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.