Bug 1905281 - Could we please list "meld" as a weak dependency for nemo-compare?
Summary: Could we please list "meld" as a weak dependency for nemo-compare?
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: nemo-extensions
Version: 37
Hardware: All
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: leigh scott
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-12-07 22:44 UTC by niohiani
Modified: 2022-12-28 01:34 UTC (History)
3 users (show)

Fixed In Version: nemo-extensions-5.6.0-1.fc37
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-12-28 01:34:48 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
nemo-extensions.spec without the unnecessary meld dependency (19.78 KB, text/plain)
2022-01-08 01:20 UTC, niohiani
no flags Details
nemo-extensions.spec without the unnecessary meld dependency (19.78 KB, text/plain)
2022-01-08 01:21 UTC, niohiani
no flags Details

Description niohiani 2020-12-07 22:44:38 UTC
Description of problem: When installing nemo-compare from the official Fedora repos, the Meld package is treated as a dependency. This should not be the case, as there are other diff utilities out there (such as Diffuse, which is supported by the extension OOTB).

Additional info: I have been hosting builds of this package with the Meld dependency removed, here: https://copr.fedorainfracloud.org/coprs/niohiani/Diffuse-Python-3/package/nemo-extensions/ and am utilizing nemo-compare with another diff tool (Diffuse). Everything works as it should.

Comment 1 leigh scott 2020-12-07 23:37:02 UTC
Sorry I'm not interested in changing from meld.

Comment 2 niohiani 2020-12-08 00:48:36 UTC
You misunderstood.

It's as simple as doing the following:
- Deleting "Requires:    meld" from the spec file.

You wouldn't be switching from Meld. You would simply be removing Meld as a dependency from the nemo-extensions package, so that people who use other diff utilities are free to take advantage of the nemo-compare extension, without having to install a diff utility they do not use.

It's removing Meld as a dependency, not making Diffuse (or any other diff tool) a dependency.

The extension works with Meld, but it does not need Meld to function, and Meld is not the only diff tool which the extension supports. This is clear on line #37 of the utils.py file in the source of the nemo-compare extension, where it lists the diff tools it is compatible with ("PREDEFINED_ENGINES = ['meld', 'kdiff3', 'diffuse', 'kompare', 'fldiff', 'tkdiff']").

That's it.

Optionally, you could remove the commented out line containing "meld" from the setup.py file in the nemo-compare subdirectory, then move the bracket to the end of the preceding line, but that's completely unnecessary.

TLDR: There is absolutely no reason to force people who wish to use nemo-compare, to install Meld and its related dependencies. The package does not require Meld. The spec file should not list Meld as a requirement for installation. The extension works perfectly without Meld installed.

Comment 3 Ankur Sinha (FranciscoD) 2021-07-19 08:40:44 UTC
Hi Leigh,

I think the request here is to use "Recommends: meld" instead of "Requires: meld", since it's an optional dependency, and one of a set of tools that can fulfil the required functions. That'll still imply that meld is the preferred tool by default, but it'll allow more advanced users to use another tool instead of meld if they'd like to.

Would you please reconsider this? 

Cheers,
Ankur

Comment 4 niohiani 2021-07-19 20:58:02 UTC
Thank you for clarifying my report, Ankur. Much appreciated, and that is exactly what I was attempting to convey.

Comment 5 Ben Cotton 2021-11-04 13:50:16 UTC
This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 6 Ben Cotton 2021-11-04 14:19:40 UTC
This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 7 Ben Cotton 2021-11-04 15:17:25 UTC
This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 8 Ben Cotton 2021-11-30 19:01:45 UTC
Fedora 33 changed to end-of-life (EOL) status on 2021-11-30. Fedora 33 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 9 niohiani 2022-01-08 01:20:00 UTC
Created attachment 1849519 [details]
nemo-extensions.spec without the unnecessary meld dependency

Comment 10 niohiani 2022-01-08 01:21:00 UTC
Created attachment 1849520 [details]
nemo-extensions.spec without the unnecessary meld dependency

Comment 11 Ben Cotton 2022-02-08 21:15:49 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 36 development cycle.
Changing version to 36.

Comment 12 niohiani 2022-11-10 20:43:29 UTC
This bug would be resolved by a very simple change to the package's spec file.

Comment 13 Fedora Update System 2022-12-19 22:46:26 UTC
FEDORA-2022-ea0dcd2bfb has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-ea0dcd2bfb

Comment 14 Fedora Update System 2022-12-20 01:29:03 UTC
FEDORA-2022-ea0dcd2bfb has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-ea0dcd2bfb`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-ea0dcd2bfb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2022-12-28 01:34:48 UTC
FEDORA-2022-ea0dcd2bfb has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.