Bug 1905319 - cluster-samples-operator containers are not requesting required memory resource
Summary: cluster-samples-operator containers are not requesting required memory resource
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Samples
Version: 4.7
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.7.0
Assignee: Gabe Montero
QA Contact: XiuJuan Wang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-12-08 03:14 UTC by W. Trevor King
Modified: 2021-02-24 15:40 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: OCP wide guidelines for control plane components now exist, mandating declaration of k8s resource requests for CPU and memory, as well as refraining from attempting to describe limits. Samples operator needed to become compliant with this guideline. Consequence: If not addressed, samples operator would be deemed a non-compliant control plane resident, and could potentially hamper administrators maintenance of clusters. Fix: While samples operator did not describe limits, and it already set requests for CPU, it was not doing so for memory. That was addressed. Result: Samples operator is not compliant with respect to control plane component requirements around resource requests/limits for CPU and memory
Clone Of:
Environment:
Last Closed: 2021-02-24 15:40:33 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-samples-operator pull 348 0 None closed Bug 1905319: request required minimal mem resource per openshift conventions 2021-02-09 19:47:36 UTC
Red Hat Product Errata RHSA-2020:5633 0 None None None 2021-02-24 15:40:50 UTC

Description W. Trevor King 2020-12-08 03:14:16 UTC
This bug was initially created as a copy of Bug #1905298, but for the samples operator.  Containers must set both of these going forward [1], while [2] is showing:

openshift-cluster-samples-operator/cluster-samples-operator-6bd465d548-tdkg7 container containers[0] (cluster-samples-operator) is not requesting required resources: memory
openshift-cluster-samples-operator/cluster-samples-operator-6bd465d548-tdkg7 container containers[1] (cluster-samples-operator-watch) is not requesting required resources: memory

as part of failing:

  [sig-arch] Managed cluster should ensure control plane containers have requests set for cpu and memory [Suite:openshift/conformance/parallel]

origin/25747 is in flight to transition an existing, but overly relaxed, test-case to explicitly require both requests on all containers.  Any components which have not been fixed after an initial pass will have temporary exceptions linked to their tracking bugs when the stricter test lands.

[1]: https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#resources-and-limits
[2]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/25747/pull-ci-openshift-origin-master-e2e-gcp/1336048716389289984

Comment 2 XiuJuan Wang 2020-12-09 05:43:55 UTC
Verified on 4.7.0-0.nightly-2020-12-09-012634 cluster.
samples operator pod has requested memory and cpu.

oc get pods cluster-samples-operator-5c6c6dcc77-7dz8d -o yaml  | grep  resource -B 1 -A 3

    name: cluster-samples-operator
    resources:
      requests:
        cpu: 10m
        memory: 50Mi
--
    name: cluster-samples-operator-watch
    resources:
      requests:
        cpu: 10m
        memory: 50Mi

Comment 5 errata-xmlrpc 2021-02-24 15:40:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633


Note You need to log in before you can comment on or make changes to this bug.