Created attachment 1737762 [details]
libffi3.1-3.1-28.fc34.src.rpm

Attaching SRPM.

Since this is a compatibility package it is excluded from review requirements.

https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/#_package_review_process

"The package is being created so that multiple versions of the same package can coexist in the distribution (or coexist between EPEL and RHEL). The package MUST be properly named according to the naming guidelines and MUST NOT conflict with all other versions of the same package."

Proper naming is being followed, we are using libffi3.1 to ship the version 3.1 of libffi (no delimiter required).

I am moving directly now to request the package be created.

Package LGTM... review notes follow.

[x] MUST: rpmlint must be run on the source rpm and all binary rpms the
    build produces. The output should be posted in the review.(refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint)

libffi3.1.x86_64: W: spelling-error %description -l en_US libffi -> bailiff
libffi3.1.src: W: spelling-error %description -l en_US libffi -> bailiff
libffi3.1-devel.x86_64: W: spelling-error %description -l en_US libffi -> bailiff
libffi3.1-devel.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 4 warnings.

[x] MUST: The package must be named according to the
    http://fedoraproject.org/wiki/Packaging/NamingGuidelines
[x] MUST: The spec file name must match the base package
    %{name}, in the format %{name}.spec unless your
    package has an exemption. (refer to
    http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name).
[x] MUST: The package must meet the
    http://fedoraproject.org/wiki/Packaging/Guidelines.
[x] MUST: The package must be licensed with a Fedora approved license and
    meet the http://fedoraproject.org/wiki/Packaging/LicensingGuidelines.
[x] MUST: The License field in the package spec file must match the actual
    license. (refer to
    http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShortNames)
[x] MUST: If (and only if) the source package includes the text of the
    license(s) in its own file, then that file, containing the text of the
    license(s) for the package must be included in %doc.(refer to
    http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License Text)
[x] MUST: The spec file must be written in American English. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#summary)
[x] MUST: The spec file for the package MUST be legible. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#Spec_Legibility)
[x] MUST: The sources used to build the package must match the upstream
    source, as provided in the spec URL. Reviewers should use md5sum for this task.
    If no upstream URL can be specified for this package, please see the
    http://fedoraproject.org/wiki/Packaging/SourceURL for how to deal with
    this.
[x] MUST: The package MUST successfully compile and build into
    binary rpms on at least one primary architecture. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#Architecture_Support)
[-] MUST: If the package does not successfully compile, build or work on
    an architecture, then those architectures should be listed in the spec in
    ExcludeArch. Each architecture listed in ExcludeArch
    MUST have a bug filed in bugzilla, describing the reason that the package
    does not compile/build/work on that architecture. The bug number MUST be
    placed in a comment, next to the corresponding ExcludeArch line.
    (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#Architecture_Build_Failures)
[x] MUST: All build dependencies must be listed in
    BuildRequires, except for any that are listed in the
    http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 section of the
    Packaging Guidelines ; inclusion of those as BuildRequires is
    optional. Apply common sense.
[-] MUST: The spec file MUST handle locales properly. This is done by
    using the %find_lang macro. Using
    %{_datadir}/locale/* is strictly forbidden.(refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files)
[x] MUST: Every binary RPM package (or subpackage) which stores shared
    library files (not just symlinks) in any of the dynamic linker's default paths,
    must call ldconfig in %post and %postun. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries)
[x] MUST: Packages must NOT bundle copies of system libraries.(refer to
    http://fedoraproject.org/wiki/Packaging:Guidelines#Duplication_of_system_libraries)
[x] MUST: If the package is designed to be relocatable, the packager must
    state this fact in the request for review, along with the rationalization for
    relocation of that specific package. Without this, use of Prefix: /usr is
    considered a blocker. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#RelocatablePackages)
[x] MUST: A package must own all directories that it creates. If it does
    not create a directory that it uses, then it should require a package which
    does create that directory.  (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#FileAndDirectoryOwnership)
[x] MUST: A Fedora package must not list a file more than once in the spec
    file's %files listings. (Notable exception: license texts in specific
    situations)(refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles)
[x] MUST: Permissions on files must be set properly. Executables should be
    set with executable permissions, for example. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions)
[x] MUST: Each package must consistently use macros. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#macros)
[x] MUST: The package must contain code, or permissable content. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#CodeVsContent)
[-] MUST: Large documentation files must go in a -doc subpackage. (The
    definition of large is left up to the packager's best judgement, but is not
    restricted to size. Large can refer to either size or quantity). (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation)
[x] MUST: If a package includes something as %doc, it must not affect the
    runtime of the application. To summarize: If it is in %doc, the program must
    run properly if it is not present. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation)
[x] MUST: Header files must be in a -devel package. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages)
[-] MUST: Static libraries must be in a -static package. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries)
[x] MUST: If a package contains library files with a suffix (e.g.
    libfoo.so.1.1), then library files that end in .so (without suffix) must go in
    a -devel package. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages)
[x] MUST: In the vast majority of cases, devel packages must require the
    base package using a fully versioned dependency: Requires:
    %{name}%{?_isa} = %{version}-%{release}  (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage)
[x] MUST: Packages must NOT contain any .la libtool archives, these must
    be removed in the spec if they are built.(refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries)
[-] MUST: Packages containing GUI applications must include a
    %{name}.desktop file, and that file must be properly installed with
    desktop-file-install in the %install section. If you feel that your packaged
    GUI application does not need a .desktop file, you must put a comment in the
    spec file with your explanation. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#desktop)
[x] MUST: Packages must not own files or directories already owned by
    other packages. The rule of thumb here is that the first package to be
    installed should own the files or directories that other packages may rely
    upon. This means, for example, that no package in Fedora should ever share
    ownership with any of the files or directories owned by the
    filesystem or man package. If you feel that you have a good reason to own
    a file or directory that another package owns, then please present that at
    package review time. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#FileAndDirectoryOwnership)
[x] MUST: All filenames in rpm packages must be valid UTF-8. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#FilenameEncoding)

[-] SHOULD: If the source package does not include license text(s) as a
    separate file from upstream, the packager SHOULD query upstream to include it.
    (refer to
    http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text)
[-] SHOULD: The description and summary sections in the package spec file
    should contain translations for supported Non-English languages, if available.
    (refer to http://fedoraproject.org/wiki/Packaging/Guidelines#summary)
[x] SHOULD: The reviewer should test that the package builds in mock.
    (refer to http://fedoraproject.org/wiki/PackageMaintainers/MockTricks)
[x] SHOULD: The package should compile and build into binary rpms on all
    supported architectures. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#ArchitectureSupport)
[x] SHOULD: The reviewer should test that the package functions as
    described. A package should not segfault instead of running, for example.
[x] SHOULD: If scriptlets are used, those scriptlets must be sane. This is
    vague, and left up to the reviewers judgement to determine sanity. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#Scriptlets)
[-] SHOULD: Usually, subpackages other than devel should require the base
    package using a fully versioned dependency. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage)
[x] SHOULD: The placement of pkgconfig(.pc) files depends on their
    usecase, and this is usually for development purposes, so should be placed in a
    -devel pkg.  A reasonable exception is that the main pkg itself is a devel tool
    not installed in a user runtime, e.g. gcc or gdb. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#PkgconfigFiles)
[-] SHOULD: If the package has file dependencies outside of /etc, /bin,
    /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the
    file instead of the file itself. (refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#FileDeps)
[-] SHOULD: your package should contain man pages for binaries/scripts. If
    it doesn't, work with upstream to add them where they make sense.(refer to
    http://fedoraproject.org/wiki/Packaging/Guidelines#Man_pages)

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/libffi3.1

Package is available in repos, closing ticket.