Bug 1906355 - must-gather may fail to collect node logs
Summary: must-gather may fail to collect node logs
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Performance Addon Operator
Version: 4.7
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 4.7.0
Assignee: Francesco Romani
QA Contact: Gowrishankar Rajaiyan
URL:
Whiteboard:
Depends On:
Blocks: 1913675 1913676
TreeView+ depends on / blocked
 
Reported: 2020-12-10 11:22 UTC by Francesco Romani
Modified: 2022-08-26 13:57 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: Incorrect wait in must-gather internals leads to too early termination of log gathering Consequence: Depending on timing, thus unpredictably, the log gathering operation may be interrupted prematurely, leading to partial log collection. Fix: Add correct wait in must-gather Result: Log gathering is now atomic and expected to succeed, or clear error reported.
Clone Of:
: 1913675 (view as bug list)
Environment:
Last Closed: 2022-08-26 13:57:42 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift-kni performance-addon-operators pull 464 0 None closed Bug 1906355: must-gather: wait when gathering node logs 2021-02-16 12:04:06 UTC

Description Francesco Romani 2020-12-10 11:22:31 UTC
Description of problem:
Due to a bug in the collection logic, there is a good chance that must-gather fails to collect the node logs randomly - and without a good reason.


Version-Release number of selected component (if applicable):
4.6


How reproducible:
Hard to predict, strongly related to timing. We expect this to happen pretty often


Steps to Reproduce:
1. just run the performance-addon must-gather image

Actual results:
node logs are missing with random chance (hard to predict). No error is reported if the logs are missing.

Expected results:
node logs should be collected 100% of times OR a clear error should be emitted if node logs can't be collected.

Comment 2 Denys Shchedrivyi 2021-01-12 21:38:05 UTC
verified on performance-addon-operator-must-gather-rhel8-container-v4.7.0-35


Note You need to log in before you can comment on or make changes to this bug.