Bug 1906433
| Summary: | review request: sushy-tools | ||
|---|---|---|---|
| Product: | [Community] RDO | Reporter: | Riccardo Pittau <rpittau> |
| Component: | Package Review | Assignee: | Yatin Karel <ykarel> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | hguemar |
| Severity: | medium | Docs Contact: | |
| Priority: | high | ||
| Version: | trunk | CC: | ykarel |
| Target Milestone: | --- | Flags: | ykarel:
rdo-review+
|
| Target Release: | trunk | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-01-27 14:52:35 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1895299 | ||
|
Description
Riccardo Pittau
2020-12-10 14:00:49 UTC
The spec looks good at first glance, I suggest you proceed to the next steps in the packaging guide. $ licensecheck -r .|grep -v UNKNOWN ./LICENSE: *No copyright* Apache License (v2.0) ./setup.cfg: *No copyright* Apache License ./setup.py: Apache License (v2.0) ./sushy_tools/error.py: Apache License (v2.0) ./doc/source/conf.py: *No copyright* Apache License (v2.0) ./releasenotes/source/conf.py: *No copyright* Apache License (v2.0) GENERATED FILE ./sushy_tools/emulator/base.py: Apache License (v2.0) ./sushy_tools/emulator/constants.py: Apache License (v2.0) ./sushy_tools/emulator/main.py: Apache License (v2.0) ./sushy_tools/emulator/memoize.py: Apache License (v2.0) ./sushy_tools/static/main.py: Apache License (v2.0) ./sushy_tools/emulator/resources/base.py: Apache License (v2.0) ./sushy_tools/emulator/resources/chassis.py: Apache License (v2.0) ./sushy_tools/emulator/resources/drives.py: Apache License (v2.0) ./sushy_tools/emulator/resources/indicators.py: Apache License (v2.0) ./sushy_tools/emulator/resources/managers.py: *No copyright* Apache License (v2.0) ./sushy_tools/emulator/resources/storage.py: Apache License (v2.0) ./sushy_tools/emulator/resources/vmedia.py: Apache License (v2.0) ./sushy_tools/emulator/resources/volumes.py: Apache License (v2.0) ./sushy_tools/tests/unit/base.py: Apache License (v2.0) ./sushy_tools/emulator/resources/systems/base.py: Apache License (v2.0) ./sushy_tools/emulator/resources/systems/libvirtdriver.py: Apache License (v2.0) ./sushy_tools/emulator/resources/systems/novadriver.py: Apache License (v2.0) ./sushy_tools/tests/unit/emulator/test_main.py: *No copyright* Apache License (v2.0) ./sushy_tools/tests/unit/emulator/test_memoize.py: Apache License (v2.0) ./sushy_tools/tests/unit/emulator/resources/test_chassis.py: Apache License (v2.0) ./sushy_tools/tests/unit/emulator/resources/test_drives.py: Apache License (v2.0) ./sushy_tools/tests/unit/emulator/resources/test_indicators.py: Apache License (v2.0) ./sushy_tools/tests/unit/emulator/resources/test_managers.py: Apache License (v2.0) ./sushy_tools/tests/unit/emulator/resources/test_storage.py: Apache License (v2.0) ./sushy_tools/tests/unit/emulator/resources/test_vmedia.py: Apache License (v2.0) ./sushy_tools/tests/unit/emulator/resources/test_volumes.py: Apache License (v2.0) ./sushy_tools/tests/unit/emulator/resources/systems/test_libvirt.py: *No copyright* Apache License (v2.0) ./sushy_tools/tests/unit/emulator/resources/systems/test_nova.py: Apache License (v2.0) License is ASL 2.0. Fedora review output:- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file license.png is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License (v2.0)", "*No copyright* Apache License", "Apache License (v2.0)". 93 files have unknown license. Detailed output of licensecheck in /tmp/python- sushy-tools/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/systemd/system, /usr/lib/systemd [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [!]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: python3-sushy-tools-tests (description) [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in python3-sushy-tools [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-sushy-tools , python3-sushy-tools-tests [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [!]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define upstream_version 0.14.0 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-sushy-tools-0.14.0-0.20210112114354.4b71614.el8.noarch.rpm python3-sushy-tools-tests-0.14.0-0.20210112114354.4b71614.el8.noarch.rpm python-sushy-tools-doc-0.14.0-0.20210112114354.4b71614.el8.noarch.rpm python-sushy-tools-0.14.0-0.20210112114354.4b71614.el8.src.rpm python3-sushy-tools.noarch: E: no-changelogname-tag python3-sushy-tools.noarch: W: no-documentation python3-sushy-tools.noarch: W: non-standard-gid /etc/sushy-emulator sushy-tools python3-sushy-tools.noarch: W: non-standard-gid /etc/sushy-emulator/sushy-emulator.conf sushy-tools python3-sushy-tools.noarch: E: non-readable /etc/sushy-emulator/sushy-emulator.conf 640 python3-sushy-tools.noarch: E: zero-length /etc/sushy-emulator/sushy-emulator.conf python3-sushy-tools.noarch: W: no-manual-page-for-binary sushy-emulator python3-sushy-tools.noarch: W: no-manual-page-for-binary sushy-static python3-sushy-tools-tests.noarch: W: summary-not-capitalized C sushy-tools tests python3-sushy-tools-tests.noarch: W: unexpanded-macro %description -l C %{common_desc_tests} python3-sushy-tools-tests.noarch: W: spelling-error %description -l en_US desc -> disc, desk, descry python3-sushy-tools-tests.noarch: E: no-changelogname-tag python3-sushy-tools-tests.noarch: W: no-documentation python-sushy-tools-doc.noarch: W: summary-not-capitalized C sushy-tools documentation python-sushy-tools-doc.noarch: E: no-changelogname-tag python-sushy-tools.src: E: no-changelogname-tag python-sushy-tools.src: W: invalid-url Source0: sushy-tools-0.14.0-0.20210112114354.4b71614.tar.gz 4 packages and 0 specfiles checked; 6 errors, 11 warnings. Rpmlint (installed packages) ---------------------------- python3-sushy-tools-tests.noarch: W: summary-not-capitalized C sushy-tools tests python3-sushy-tools-tests.noarch: W: unexpanded-macro %description -l C %{common_desc_tests} python3-sushy-tools-tests.noarch: E: no-changelogname-tag python3-sushy-tools-tests.noarch: W: invalid-url URL: https://opendev.org/openstack/sushy-tools <urlopen error [Errno -2] Name or service not known> python3-sushy-tools-tests.noarch: W: no-documentation python3-sushy-tools.noarch: E: no-changelogname-tag python3-sushy-tools.noarch: W: invalid-url URL: https://opendev.org/openstack/sushy-tools <urlopen error [Errno -2] Name or service not known> python3-sushy-tools.noarch: W: no-documentation python3-sushy-tools.noarch: W: non-standard-gid /etc/sushy-emulator sushy-tools python3-sushy-tools.noarch: W: non-standard-gid /etc/sushy-emulator/sushy-emulator.conf sushy-tools python3-sushy-tools.noarch: E: non-readable /etc/sushy-emulator/sushy-emulator.conf 640 python3-sushy-tools.noarch: E: zero-length /etc/sushy-emulator/sushy-emulator.conf python3-sushy-tools.noarch: W: no-manual-page-for-binary sushy-emulator python3-sushy-tools.noarch: W: no-manual-page-for-binary sushy-static python-sushy-tools-doc.noarch: W: summary-not-capitalized C sushy-tools documentation python-sushy-tools-doc.noarch: E: no-changelogname-tag python-sushy-tools-doc.noarch: W: invalid-url URL: https://opendev.org/openstack/sushy-tools <urlopen error [Errno -2] Name or service not known> 3 packages and 0 specfiles checked; 5 errors, 12 warnings. Requires -------- python3-sushy-tools (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python3 config(python3-sushy-tools) python(abi) python3-flask python3-pbr python3-requests python3-tenacity python3-sushy-tools-tests (rpmlib, GLIBC filtered): python(abi) python3-libvirt python3-munch python3-openstacksdk python3-oslotest python3-sushy-tools python3-testscenarios python3-testtools python-sushy-tools-doc (rpmlib, GLIBC filtered): Provides -------- python3-sushy-tools: config(python3-sushy-tools) python3-sushy-tools python3.6dist(sushy-tools) python3dist(sushy-tools) python3-sushy-tools-tests: python3-sushy-tools-tests python-sushy-tools-doc: python-sushy-tools-doc Few things noted and asked for correction on review itself https://review.rdoproject.org/r/#/c/31385/, some of the things are exempted:- - Changelog, source0 and %define are used by package build tool DLRN. Package is Approved. Available since Wallaby, closing. |