Bug 1906732 - Machine API proxy support should be tested
Summary: Machine API proxy support should be tested
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Cloud Compute
Version: 4.7
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.7.0
Assignee: Joel Speed
QA Contact: Milind Yadav
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-12-11 10:16 UTC by Joel Speed
Modified: 2021-02-24 15:42 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: Machine API ignored proxy settings Consequence: Machine API traffic was not routed via a configured proxy Fix: Ensure Machine API observes proxy settings Result: Machine API traffic now routes via a configured proxy
Clone Of:
Environment:
Last Closed: 2021-02-24 15:42:26 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-api-actuator-pkg pull 192 0 None closed Bug 1906732: Add E2E to ensure Cluster Wide Proxies are honoured in Machine API components 2021-01-04 11:42:57 UTC
Red Hat Product Errata RHSA-2020:5633 0 None None None 2021-02-24 15:42:45 UTC

Description Joel Speed 2020-12-11 10:16:24 UTC
Description of problem:

Machine API recently introduced support for honouring cluster wide proxies. This support should be tested in our E2E suite to ensure we do not regress on this feature in the future

Comment 4 Joel Speed 2021-01-04 11:48:59 UTC
@miyadav I've reviewed the links you attached. Neither of these failures are related to the machine api, but rather machine config which is not affected by the changes we introduced in 4.7.

I had a look through the CI search system and couldn't find failures related to the tests that were added in the linked PR since it has merged. I don't believe any further verification is required for E2E tests like this, I think this can be moved to verified?

Comment 5 Milind Yadav 2021-01-05 02:47:33 UTC
Thanks for Reviewing @Joel .

I wasn't sure , if the failure were linked or not , so moved to Assigned , Can you help me with the artifacts , related to the above changes , which confirms successful results , so that in the future , i will follow better and not make incorrect resolution , as it might be backported as well .

Yes we can move it to VERIFIED if it looks good .

Comment 6 Joel Speed 2021-01-05 11:12:55 UTC
The linked changes for this PR are just tests, so, these tests run on Machine API related repositories and are part of the `e2e-<platform>-operator`. If the tests were to fail, we have a JUNIT section which would highlight the failures at the top of the test page.

For the two items you linked, I took a look at the machines.json in /artifacts/e2e-aws-proxy/gather-extra/ which shows all the machines running as expected and also took a look at the machine api component logs in /artifacts/e2e-aws-proxy/gather-extra/pods/, there were no obvious errors there.

This particular change won't be backported as far as I'm aware, we certainly have no plan to do so at the moment

Comment 7 Milind Yadav 2021-01-06 02:29:41 UTC
Looks like a unit test , hence moving to VERIFIED , based on no issues seen related to these.

Comment 9 errata-xmlrpc 2021-02-24 15:42:26 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633


Note You need to log in before you can comment on or make changes to this bug.